* The tooltip mis-taught every pure enabler. JCA.explain used a cluster
tag's `both` text whenever EITHER side was a full member, so Four
Fingers next to Runner claimed "both reward Straights" -- Four Fingers
does not reward Straights, it makes them reachable. `both` now requires
both sides, and every cluster tag carries give/want phrasings.
* Blue Joker and Abstract Joker scored 0 against all 150 jokers. Blue
Joker scales on #G.deck.cards, so it wants card_gen (DNA, Marble,
Certificate); Abstract scales on #G.jokers.cards, so it wants joker_gen
(Riff-Raff is +6 Mult on its own). Both verified in card.lua. Steel and
Glass Joker look like the same fix but are NOT: they need Steel/Glass
specifically, and the only enhance_gen givers make Gold and Stone, so
tagging them would invent a synergy that does not exist.
* Copy jokers are positional and the board order was there all along.
JCA.copy_source reports what an owned Blueprint/Brainstorm is actually
copying, including when the target is one of the 29 centers vanilla
refuses to copy (blueprint_compat = false), or when it is copying
nothing at all.
* The sell advisor now counts clashes when ranking what to cut. JCA.score
stays pure -- a trap must never make a card look like a combo -- but a
joker eating another one's payoff is exactly the one to sell.
The suite caught a real bug while writing this: `(mode == 'right') and
cards[idx+1] or cards[1]` falls through to the LEFTMOST joker when the
right-hand slot is nil, so a rightmost Blueprint would have named the
wrong card. 673 pass here, 9 in-game via the smoke harness.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was no test file -- CLAUDE.md described the harness in prose and
referred to an "orphan-tag check" that did not exist. test.lua now stubs
the game globals and exercises the real engine, database and catalog tab
builders. It found three bugs on its first run:
* four_kind was the only theme in the catalog that could never be
discovered. Theme discovery needs a giver and a wanter on two DIFFERENT
fielded jokers, and The Family was its sole member -- so the Hands bar
and the overall Progress bar could never reach 100%. DNA is the real
enabler (copying a card is how you stack duplicate ranks, the only
vanilla route to a reliable Four of a Kind), so it now gives the
matching-hand tags as a pure enabler.
* hand_level was given by Space Joker and Burnt Joker and wanted by
nobody, so it could never contribute to a score and its "want" tooltip
text was unreachable. Nothing in vanilla rewards hand levels; the tag
is dropped rather than faked.
* Invisible Joker had no tags at all, so it scored 0 against the entire
game. Selling it duplicates one of your Jokers -- the same "stronger
target, better payoff" logic Blueprint and Brainstorm already model --
so it now wants copy_target.
The suite guards both directions of the tag contract (no orphan wants, no
dead gives), theme reachability, blurb widths, the inert-joker list, and
the card materialize fix from the previous commit.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Card rows in the Combos/theme tabs emplaced their cards without ever
calling Card:start_materialize, so cards popped in with no animation
when a tab opened or a page was switched. Every vanilla collection page
materializes as it emplaces (create_UIBox_your_collection_jokers).
Each card now materializes on emplace; begin_page() lets only the first
card of a page build play the sound, matching vanilla's i>1 or j>1
silence flag.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Other mods can teach the advisor their jokers (which otherwise score 0):
JCA.register(key, gives, wants, opts) adds a db entry with tag
validation — unknown tags are dropped with a log line so a typo can't
break anyone's load; opts.no_generic opts out of the mult/xmult
complement. register_pair adds a famous pair (discoverable, shown in
the Combos tab — its sort cache now invalidates via JCA._pairs_dirty)
and warns when a blurb exceeds the 34-char tooltip budget.
register_clash adds a warning-only trap line. Usage example in README.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fifth catalog tab (also reachable from the in-run Combos button) showing
famous pairs fielded (x/31), per-group theme exploration bars
(Engine/Economy/Hands), pairs fielded in the current run, and an overall
discoveries tally with the how-to-discover hint. Text-only UI - no live
Card objects, no pager.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JCA.weakest_link() scores each owned joker's total synergy against the
rest of the board (same capped scoring the shop advice uses) and returns
the lowest scorer — only when the board is full (that's when a cut
decision exists), has 3+ jokers, and one joker actually stands out
(uniform boards return nil). The owned-joker tooltip gains a red
'Weakest combo piece - a sell candidate' verdict line, suppressed in
learning mode like the other verdicts. Config toggle: sell_advisor.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
While hovering a shop/pack joker (or an owned one), the owned jokers it
synergizes with juice gently every ~0.9s, so the tooltip's partner names
are matched to cards by eye. Partner set is computed once per hover and
dropped when it ends. New config toggle: partner_highlight (default on);
stays active in learning mode since it explains rather than judges.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Warning-only data in synergies.lua — never touches the synergy score.
Tooltips gain a red 'Clashes - <owned joker>: <why>' line when a hovered
joker fights one you own (Ride the Bus + Pareidolia, Vampire vs Steel
Joker/Lucky Cat, Smeared vs Flower Pot), and a 'Caution:' line in the
buy area for jokers that harm a board you keep (Ceremonial Dagger,
Madness, Stencil). Learning mode keeps warnings — they teach.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Any xMult joker used to pulse 'recommended' on a board of four unrelated
+Mult/+Chips jokers: the generic engine-complement +1 in JCA.score
accumulated once per owned joker in partners_for, reaching the threshold
of 4 with zero listable partners (pairwise scores never hit 2), so the
card pulsed while its own tooltip said 'No synergy with your jokers.'
- partners_for now counts the generic +1 once per candidate. Tag/pair
scores are even, so the generic bonus can no longer flip a
recommendation at all; a pulsing card always has a nameable partner.
- Joker Stencil is the one xMult joker the generic rule actively
misreads (its multiplier grows with EMPTY slots), so entries support
{no_generic = true} which suppresses the rule in score() and the
generic fallback lines in explain(). Stencil also gains copy_target:
its real famous synergy is being copied by Blueprint/Brainstorm.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
A synergy theme counts as explored the first time two different
fielded jokers connect it (one gives the tag, one wants it; cluster
members carry both sides, so any two qualify). Explored themes
persist in config.themes_found, badge their catalog page with
"explored!", and feed a per-tab progress line. One toast per
emplacement, with famous pairs outranking themes.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Steamodded mod that teaches Balatro joker synergies: hover tooltips
explain why jokers combo (famous-pair blurbs + tag-based reasons),
combo discovery tracking with catalog grey-out and run recap, an
in-game synergy catalog with real card sprites, learning mode, and
a HUD shortcut.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
funman300