Ferrous-Solitaire/SESSION_HANDOFF.md

Solitaire Quest — Session Handoff

Last updated: 2026-05-12 — ARCHITECTURE.md updated to v1.3 (all 8 Phase 8 gaps closed); SESSION_HANDOFF.md updated. Push pending.

Phase 8 closes the self-hosted-server connection arc end-to-end: login/register modal, re-auth on token expiry, account deletion flow, server deployment artifacts (Dockerfile + docker-compose), replay upload on win, web replay player (WASM + HTML/CSS/JS served by the server), leaderboard opt-in/out, and full server integration tests.

---

Current state

• HEAD locally: bd388fe (docs: CHANGELOG Phase 8 entry).
• HEAD on origin: 272d31f (feat: account deletion — last pushed commit).
• Working tree: ARCHITECTURE.md + SESSION_HANDOFF.md modified, uncommitted.
• Build: cargo clippy --workspace --all-targets -- -D warnings clean.
• Tests: 1300+ passing / 0 failing across the workspace.
• Tags on origin: v0.9.0 through v0.22.0.

---

What shipped in Phase 8 (432061c – bd388fe)

Commit	Summary
432061c	Sync setup modal (login/register/connect/disconnect)
6ce5564	Re-auth on expired session + server deployment artifacts
272d31f	Account deletion flow + handle_sync_buttons refactor
bd388fe	CHANGELOG v0.23.0 documentation

Also shipped (pre-Phase 8 but post-v0.22.0, already in CHANGELOG):

• solitaire_wasm crate: WASM ReplayPlayer bindings for browser-side replay playback
• Server replay API: POST /api/replays, GET /api/replays/recent, GET /api/replays/:id
• Server web UI: /replays/:id HTML route + ServeDir /web static assets
• DB migration 002: replays table + two indexes
• Full server integration tests for replay endpoints
• push_replay in sync_plugin (uploads on win, writes share URL into replay history)
• Stats panel "Copy Share Link" button reads share_url from replay history

---

Open punch list (ordered by priority)

1. Documentation debt (no code)

• CHANGELOG [Unreleased] → v0.23.0 — done this session
• ARCHITECTURE.md update — all 8 gaps closed, bumped to v1.3
• SESSION_HANDOFF.md update — this file

2. Leaderboard wiring gaps

• Best-score auto-post missing. POST /api/sync/push merges stats/achievements/ progress but never touches the leaderboard table. Players who opt in never have their best_time_secs / best_score updated automatically. Fix: update the leaderboard row inside the server's sync push handler (or on GameWonEvent via a new async task in sync_plugin).
• Display name = username. handle_opt_in_button uses the SyncBackend username as the leaderboard display name. Consider adding leaderboard_display_name: Option<String> to Settings for players who want a different public identity.

3. Security hardening

• Refresh token rotation. POST /api/auth/refresh returns only a new access token; the refresh token never rotates. Standard mitigation: issue a new refresh token on each call and invalidate the old one (needs a last_refresh_token column or a separate table).
• Sync endpoint rate limiting. Only /api/auth/* has tower-governor; /api/sync/push (1 MB body) has no per-user throttle.

4. Android validation

• Android Keystore functional test — JNI AES-GCM code ships (f281425) but no AVD round-trip test has been run. Required before Phase 8 sync goes live on Android.
• JNI clipboard functional test — same status (2c822ba). Note: adb tap doesn't work in headless AVD (see memory); requires a touch-gesture path.
• cargo apk build --lib noisy stderr — post-sign panic doesn't affect the APK but pollutes CI output. Document --lib as canonical or upstream a fix.

5. Feature completeness

• Theme importer UI. import_theme() (Phase 7, theme/importer.rs) is complete but has no Settings button trigger. Players must copy theme files manually.
• mirror_achievement decision. SyncProvider has this method with a no-op default; SolitaireServerClient never overrides it, no server endpoint exists. Either implement (POST /api/achievements/mirror + client call on AchievementUnlockedEvent) or delete from the trait.
• WASM build script. web/pkg/ contains compiled WASM committed to git. Need a build_wasm.sh or Makefile target documenting the wasm-pack build invocation to regenerate it.
• Server password reset. No admin endpoint or CLI tool for resetting a user's password. Self-hosters have no recovery path short of direct SQLite edits.

6. Testing gaps

• Server 401 → refresh → retry path — the pull/push retry logic in SolitaireServerClient has no integration test.
• WASM winning-replay step-through — current tests cover 2 stock clicks; a test stepping through a full winning sequence would catch GameState/ReplayMove compatibility regressions.

---

ARCHITECTURE.md gaps (for the update pass)

Items missing from the doc:

1. solitaire_wasm crate (§2 workspace + §3 responsibilities)
2. Replay API endpoints (§9 API Reference — 3 new routes)
3. Web replay player route (/replays/:id + ServeDir /web)
4. SyncProvider trait: 6 added methods
5. Theme system in Bevy plugin table (§5)
6. Settings new fields: color_blind_mode, high_contrast_mode, reduce_motion_mode, window_geometry, selected_card_back, selected_background
7. DB migration 002 (§7)
8. Update "Last Updated" date

---

Process notes

• Commit attribution: use funman300 as git user. Co-author line: Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>.
• Commit format: type(scope): description per CLAUDE.md §7.
• Never commit without: cargo test --workspace passing + clippy clean.
• Sub-agents stage/verify only; orchestrator commits.
• CARD_PLAN.md referenced in theme/ module comments but not present in repo. Clean up references or commit the file.
• Token-port pattern (v0.20.0): when migrating tokens, walk every concrete artifact downstream — PNGs, SVGs, literals, comments. Three "walked past this" follow-ups in v0.21.0 all had this shape.

---

Resume prompt

You are a senior Rust + Bevy developer working on Solitaire Quest.
Working directory: <Rusty_Solitaire clone path>.
Branch: master. v0.23.0 is the current version (HEAD locally: bd388fe).
Phase 8 sync is fully shipped. ARCHITECTURE.md is now v1.3 (all Phase 8 gaps closed).
Push to origin pending (bd388fe + ARCHITECTURE.md + SESSION_HANDOFF.md commits).

READ FIRST (in order):
  1. SESSION_HANDOFF.md  — this file
  2. CHANGELOG.md        — [0.23.0] section has the full Phase 8 detail
  3. CLAUDE.md           — unified-3.0 rule set
  4. ARCHITECTURE.md     — v1.3, fully up to date
  5. docs/ui-mockups/    — design system + mockup library
  6. docs/android/       — Android setup + build runbook
  7. ~/.claude/projects/<this-project>/memory/MEMORY.md

OPEN WORK (in priority order):
  B. Leaderboard best-score auto-post (server sync handler + optional
     GameWonEvent path in sync_plugin)
  C. Refresh token rotation (server auth handler + new column/table)
  D. Android AVD functional tests (Keystore + clipboard)
  E. Theme importer UI button in Settings
  F. mirror_achievement: decide + implement or remove from trait

Ask which to start. All are independent; any is a valid next arc.