funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 48 Wiki Activity

refactor(engine): split settings_plugin runtime code into submodules #127

Merged
funman300 merged 1 commits from refactor/settings-plugin-submodules into master 2026-07-06 20:46:10 +00:00
Conversation 0 Commits 1 Files Changed 5
+2367 -2314
funman300 commented 2026-07-06 20:46:09 +00:00
Owner
Copy Link
Copy Source

Second phase of #118, first runtime split: settings_plugin/mod.rs (2,857 lines) becomes four focused submodules along existing system boundaries.

File Lines Contents
mod.rs 561 types, markers, SettingsButton, plugin build, persistence + window-geometry debounce
input.rs 632 button/hotkey handlers, focus attachment, scrolling
updates.rs 495 per-frame value-text updaters + label helpers
ui.rs 1,231 spawn_settings_panel, row builders, thumbnails

Moved items are pub(super); mod.rs glob-imports the submodules so system registration and the test suite keep their bare names. Code moved verbatim — no behaviour change; all 29 settings tests pass unchanged.

  • cargo clippy --workspace -- -D warnings clean
  • cargo test --workspace green

Remaining on #118: hud_plugin and card_plugin runtime splits.

Refs #118

🤖 Generated with Claude Code

Second phase of #118, first runtime split: `settings_plugin/mod.rs` (2,857 lines) becomes four focused submodules along existing system boundaries. | File | Lines | Contents | |---|---|---| | mod.rs | 561 | types, markers, `SettingsButton`, plugin build, persistence + window-geometry debounce | | input.rs | 632 | button/hotkey handlers, focus attachment, scrolling | | updates.rs | 495 | per-frame value-text updaters + label helpers | | ui.rs | 1,231 | `spawn_settings_panel`, row builders, thumbnails | Moved items are `pub(super)`; `mod.rs` glob-imports the submodules so system registration and the test suite keep their bare names. Code moved verbatim — no behaviour change; all 29 settings tests pass unchanged. - `cargo clippy --workspace -- -D warnings` clean - `cargo test --workspace` green Remaining on #118: hud_plugin and card_plugin runtime splits. Refs #118 🤖 Generated with [Claude Code](https://claude.com/claude-code)
funman300 added 1 commit 2026-07-06 20:46:09 +00:00
refactor(engine): split settings_plugin runtime code into submodules 1ca1efb3b6 
Second phase of #118 for settings_plugin: the 2,857-line mod.rs becomes
four focused submodules along existing system boundaries —

  mod.rs     561  types, markers, SettingsButton, plugin build, persistence
  input.rs   632  button/hotkey handlers, focus attachment, scrolling
  updates.rs 495  per-frame value-text updater systems + label helpers
  ui.rs    1,231  spawn_settings_panel + row builders + thumbnails

Moved items are pub(super); mod.rs glob-imports the submodules so
system registration and tests keep their bare names. No behaviour
change; all 29 settings tests pass unchanged.

Refs #118

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
funman300 merged commit 59ba7ba4c3 into master 2026-07-06 20:46:10 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
android
bug
correctness
enhancement
performance
security
server
test
ui
ux
wasm
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#127
Delete Branch "refactor/settings-plugin-submodules"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?