fix(engine): resolve all clippy warnings introduced by PNG asset pipeline
- Collapse nested-if patterns into let-chains across 13 plugins (42 instances) - Add #[allow(clippy::too_many_arguments)] to 5 Bevy systems in card_plugin and input_plugin where ECS parameter count exceeds the lint threshold - Gate Theme import in table_plugin under #[cfg(test)] — only used by test-only colour helpers; removing the unconditional import silences the unused-import lint without breaking the test suite - Wrap ButtonInput<MouseButton> in Option<> in update_input_platform so that tests using MinimalPlugins (no InputPlugin) no longer panic on startup All 789 tests pass; cargo clippy --workspace -- -D warnings is clean. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -49,13 +49,11 @@ fn roll_weekly_goals_on_startup(
|
||||
path: Res<ProgressStoragePath>,
|
||||
) {
|
||||
let week_key = current_iso_week_key(Local::now().date_naive());
|
||||
if progress.0.roll_weekly_goals_if_new_week(&week_key) {
|
||||
if let Some(target) = &path.0 {
|
||||
if let Err(e) = save_progress_to(target, &progress.0) {
|
||||
if progress.0.roll_weekly_goals_if_new_week(&week_key)
|
||||
&& let Some(target) = &path.0
|
||||
&& let Err(e) = save_progress_to(target, &progress.0) {
|
||||
warn!("failed to save progress after weekly reset on startup: {e}");
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
fn evaluate_weekly_goals(
|
||||
@@ -114,13 +112,11 @@ fn evaluate_weekly_goals(
|
||||
}
|
||||
}
|
||||
|
||||
if any_change {
|
||||
if let Some(target) = &path.0 {
|
||||
if let Err(e) = save_progress_to(target, &progress.0) {
|
||||
if any_change
|
||||
&& let Some(target) = &path.0
|
||||
&& let Err(e) = save_progress_to(target, &progress.0) {
|
||||
warn!("failed to save progress after weekly goal update: {e}");
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// Resolve a goal id to its description (used for toasts).
|
||||
|
||||
Reference in New Issue
Block a user