funman300
21a81ad63c
Multi-agent pass over the store subsystem, 11 agents, findings run through three
adversarial verifiers. Full writeup in docs/plan-2026-08-05-store-subsystem.md.
THE REAL DISCARD TABLE IS RECOVERED. quick_sell() paid an invented rating tier
(600/300/150/50) that was wrong for every single card. The real table is
fcc_discardcoins in the client's own game DB, 141 rows keyed (cardtype, level, rare),
read out of the running client and verified 22/22 against live items:
value = round_half_up(rating * price / 100)
level = 3 if rating >= 75, 2 if 65..74, else 1 (0x180141e8a..0x180141ea3,
derived from rating, NOT a wire field)
cardtype = FUN_1800d8330(cardsubtypeid), decoded from its jump table and checked
across every subtype 0..599 with zero disagreements
A 94-rated gold rare is 752, not 600. A 76 rare is 608, not 150. A 55 bronze is 17,
not 50.
This also closes a disagreement nobody had noticed: the CLIENT already computes and
displays the correct value locally whenever our discardValue (atom 0xd7) is 0 or
absent. FUN_18013fe00 stores our value at item +0x38 and the guard at 0x180141025
skips the local computation when it is non-zero. So the screen has been showing the
real number while the server paid a made-up one, on every quick sell ever made.
Verified beyond what the report claimed, because a missing table row pays ZERO and
that would be a regression the old flat tier could not produce: across all 236 items
in the live profile, 230 map to cardtype 1 and 6 to cardtype 6, and NOT ONE would pay
0 coins. Table reproduces at 141 rows and the worked example lands exactly.
ZERO WIRE CHANGE, FUT_DISCARD_TABLE default off. Nothing new is sent; only the coin
figure the server credits moves. This is the patch worth defaulting on after one
in-game check, which is simply quick-selling a card and seeing the coins paid match
the value the card was already displaying.
THE GROUPING BUG IS NOT IN CARDSDLL, and the fix ranked first would have wasted a
launch. Live in the running client all three display groups own exactly the right
pack, there is exactly one copy of each pack record in 4 GiB, and nothing we send is
mis-parsed. The parsed model is correct and the Scaleform layer picks the wrong pack
when turning a tile click into a category id. displayGroupAssetId is served as 1/5/6
while the screen's category field reads 3, and group tiles carry a hardcoded
CATEGORY_ID of 0. Confirmed by direct read: ordinal 3, assetId 6, i.e. Premium, while
the last click was Gold.
The heap map that made this possible, all scoped to one pid: display-group vector
control block, 3 elements of 0x108; group record fields at +0x00 sortPriority,
+0x04 displayGroupAssetId, +0x40 a one-element pack vector; inner pack record 0x1a8
with packType at +0x38, ids at +0x70/+0xac, price at +0xa0, quantities at +0xc0..+0xd0.
extPrice SHOULD BE DELETED, not corrected. Both sub-parsers read only
externalPriceId; amount and currency are discarded. Sending the key at all creates an
"mtx" currency row that switches on a real-money price line the client can never fill
offline, which is the literal "or %1s" on every tile.
A WORRY NOBODY HAD RAISED, and I confirmed it from our own logs: the client has sent
packId 6 on every purchase it has ever made, four for four tonight and six for six
across history. We have never observed a successful buy of anything but Premium Gold.
Also settled: FUT_STORE_DISPLAYGROUP=0 is the right resting state, argued from
mechanism rather than from history; FUT_USERINFO=packs stays off because the
unopened-pack counter is client-mutable and the flag ladder silently drops squadList;
POST /user is a latent hard freeze that has never fired because the client never
issues that POST.
Honest coverage: the ActionScript layer is unread by everyone and every remaining
store mystery lives there.
Live: 439 contract checks pass, market suite passes, both flags off.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
34 lines
1.6 KiB
Python
34 lines
1.6 KiB
Python
"""DIMENSION 5 pass 8: the pack-record -> view-model translator, which is the consumer
|
|
of unopened(0x35d).
|
|
|
|
Found in the raw disassembly, not the decompiler: at 0x18002c7ea..0x18002c816 a
|
|
function copies BYTE [rbp+0xce] -> [rsi+0xb8] and BYTE [rbp+0xcd] -> [rsi+0x69],
|
|
where rbp is the 0x158-byte parsed pack record (it also reads +0x144/+0x148/+0x14c/
|
|
+0x150/+0x154, all inside 0x158) and rsi is a wider destination struct.
|
|
|
|
Per pass 1's offset rule (record_off = 0x268 - N in FUN_18013af30, controlled twice by
|
|
displayGroupAssetId->+0x30 and displayGroupUseDefaultImage->+0x38), +0xcd is
|
|
unopened(0x35d) and +0xce is isPremium(0x176).
|
|
|
|
CONTROL: the same routine must also move a field whose meaning is already known from
|
|
the deserializer, so the "rbp is the pack record" reading is testable. start(0x2e3) is
|
|
at record+0xb4 and the routine moves DWORD [rbp+0xb4] -> [rsi+0x84]; sortPriority
|
|
(0x2cb) is at record+0x7c and displayGroupAssetId at +0x30.
|
|
"""
|
|
import traceback, os
|
|
OUT = "/tmp/claude-1000/-home-alex-Documents-OpenFUT/8e521ca1-ca3e-4138-bb96-df1744dd1d30/scratchpad/store"
|
|
try:
|
|
f = func(0x18002c7ea)
|
|
ent = int(f.getEntryPoint().getOffset())
|
|
print("containing function %s @ %#x body %#x-%#x" % (
|
|
f.getName(), ent, ent, int(f.getBody().getMaxAddress().getOffset())))
|
|
s = dec(ent, 300)
|
|
open(os.path.join(OUT, "dec_translator_%x.c" % ent), "w").write(s)
|
|
print("declen=%d -> dec_translator_%x.c" % (len(s), ent))
|
|
print(s if len(s) < 12000 else s[:12000])
|
|
print("\n### callers")
|
|
for frm, typ, fn, e2 in xrefs_to(ent):
|
|
print(" from %#x (%s) in %s @ %#x" % (frm, typ, fn, e2))
|
|
except Exception:
|
|
traceback.print_exc()
|