funman300
a49a340a30
The Quat-flagged "≥3 tests per feature" inflation produced 43 tests
that don't earn their existence — default-value, serde-derive
round-trips on plain structs, single-field clamp tests, near-
duplicates, and trivial constant-equals-itself tests. None pin a
behaviour contract or a regression on a real bug.
Removed across `solitaire_data` and `solitaire_core`:
settings.rs −22 default-value, round-trip, legacy-format,
and per-field sanitized clamp tests. Adjust
and load-error tests retained — those exercise
real method logic.
progress.rs −1 generic round-trip on plain struct.
challenge.rs −1 challenge_count() returns CHALLENGE_SEEDS.len()
literally — testing it asserts the implementation
against itself.
game_state.rs −3 undo_count starts at 0, GameMode default is
Classic, time_attack score starts at 0 — all
default-value tests on freshly-constructed state.
card.rs −5 rank_value_ace + rank_value_king subsumed by
rank_values_are_sequential; suit_red + suit_black
consolidated into one complementarity test;
card_face_up_field_reflects_construction was
testing the struct literal.
Workspace: 1208 → 1165 passing tests (−43). clippy --workspace
--all-targets clean.
Future work: brief sub-agents for tests that pin a behaviour
contract or regression on a real bug, not a count of N. See
`feedback_test_discipline.md` in auto-memory.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
94 lines
2.7 KiB
Rust
94 lines
2.7 KiB
Rust
//! Static seed list for Challenge mode + helpers.
|
|
//!
|
|
//! Challenge mode walks a fixed sequence of hard-but-winnable seeds. The
|
|
//! player advances by winning a deal in `GameMode::Challenge`. The
|
|
//! `challenge_index` cursor is stored per-player in `PlayerProgress`.
|
|
//!
|
|
//! Seeds wrap modulo `CHALLENGE_SEEDS.len()` so a sufficiently dedicated
|
|
//! player never runs out of challenges.
|
|
|
|
/// Curated Challenge-mode seeds. Order is stable across versions; add new
|
|
/// seeds at the end.
|
|
pub const CHALLENGE_SEEDS: &[u64] = &[
|
|
// Round 1 (original 5)
|
|
0xDEAD_BEEF_CAFE_F00D,
|
|
0xC0DE_FACE_8BAD_F00D,
|
|
0xFEE1_DEAD_DEAD_BEEF,
|
|
0xBAAD_F00D_BAAD_F00D,
|
|
0x1337_C0DE_4242_BABE,
|
|
// Round 2
|
|
0xACED_CAFE_B0BA_1234,
|
|
0x5A1D_F00D_BEEF_CAFE,
|
|
0xF01D_BABE_CAFE_BEEF,
|
|
0xD00D_1E42_ABCD_EF01,
|
|
0x7EA5_ED01_2345_6789,
|
|
// Round 3
|
|
0xC1A5_51C0_F00D_CAFE,
|
|
0xBA5E_BA11_DEAD_BEEF,
|
|
0xFACE_B00C_C0DE_1010,
|
|
0x5EED_CAFE_5EED_CAFE,
|
|
0xABBA_ABBA_CAFE_BABE,
|
|
// Round 4
|
|
0x1234_5678_9ABC_DEF0,
|
|
0xFEDC_BA98_7654_3210,
|
|
0x0011_2233_4455_6677,
|
|
0x8899_AABB_CCDD_EEFF,
|
|
0x1111_2222_3333_4444,
|
|
// Round 5
|
|
0x5555_6666_7777_8888,
|
|
0x9999_AAAA_BBBB_CCCC,
|
|
0xDDDD_EEEE_FFFF_0000,
|
|
0x0101_0101_0101_0101,
|
|
0xA1B2_C3D4_E5F6_0718,
|
|
];
|
|
|
|
/// Resolve a `challenge_index` to its corresponding seed, wrapping when
|
|
/// the index exceeds the seed-list length. Returns `None` if the seed list
|
|
/// is empty (defensive — `CHALLENGE_SEEDS` is non-empty by construction).
|
|
pub fn challenge_seed_for(index: u32) -> Option<u64> {
|
|
if CHALLENGE_SEEDS.is_empty() {
|
|
return None;
|
|
}
|
|
Some(CHALLENGE_SEEDS[(index as usize) % CHALLENGE_SEEDS.len()])
|
|
}
|
|
|
|
/// Total number of currently-defined challenges. Useful for displaying
|
|
/// "Challenge {n + 1} of {total}" in UI.
|
|
pub fn challenge_count() -> u32 {
|
|
CHALLENGE_SEEDS.len() as u32
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn challenge_seed_for_0_is_first_seed() {
|
|
assert_eq!(challenge_seed_for(0), Some(CHALLENGE_SEEDS[0]));
|
|
}
|
|
|
|
#[test]
|
|
fn challenge_seed_wraps_past_end() {
|
|
let len = CHALLENGE_SEEDS.len() as u32;
|
|
assert_eq!(
|
|
challenge_seed_for(len),
|
|
Some(CHALLENGE_SEEDS[0]),
|
|
"wraps to seed 0 when index == len"
|
|
);
|
|
assert_eq!(
|
|
challenge_seed_for(len + 2),
|
|
Some(CHALLENGE_SEEDS[2]),
|
|
"wraps modulo len"
|
|
);
|
|
}
|
|
|
|
#[test]
|
|
fn all_challenge_seeds_are_unique() {
|
|
let mut seeds: Vec<u64> = CHALLENGE_SEEDS.to_vec();
|
|
seeds.sort();
|
|
let len_before = seeds.len();
|
|
seeds.dedup();
|
|
assert_eq!(seeds.len(), len_before);
|
|
}
|
|
}
|