funman300
4cb4212829
Test / test (pull_request) Successful in 36m34s
Replays previously persisted only seed + moves and re-dealt the board
from the seed at playback time, so any change to the seed->deal mapping
(RNG bumps, upstream upgrades) silently invalidated every existing
replay. Schema v4 instead embeds a SessionRecording - the upstream
card_game Session serde ({config, initial_state, instructions}) - so
playback rebuilds the exact recorded board; seed/draw_mode/mode remain
caption metadata only.
- core: SessionRecording newtype delegating to Session<Klondike> serde;
GameState::recording() / from_recording(); from_instructions_unchecked
fixture helper; serde_json added to dev-deps (tests only)
- data: Replay v4 (recording replaces moves); v1-v3 files rejected by
the existing version gate
- engine: win-recording and sync upload freeze game.recording();
playback rebuilds from the recording; Playing carries the extracted
move list (+ Box<Replay> for clippy large_enum_variant)
- wasm: replay_export() builds the full v4 upload payload so JS never
hand-assembles it (the old game.js path hardcoded schema_version: 2
and corrupted u64 seeds via Math.round); ReplayPlayer::from_json
enforces schema_version == 4 with a descriptive error
- web: game.js/play.html use replay_export; replay.js surfaces player
construction errors in the caption instead of dying silently
- server: mode validation accepts data-carrying GameMode variants
(Difficulty uploads previously 400'd against the String field)
Both replays on prod are May-era v1 rows with empty move lists - every
shared replay was already unplayable; the viewer now says why.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
28 lines
760 B
TOML
28 lines
760 B
TOML
[package]
|
|
name = "solitaire_core"
|
|
version.workspace = true
|
|
license.workspace = true
|
|
edition.workspace = true
|
|
|
|
[features]
|
|
default = []
|
|
test-support = []
|
|
|
|
[dev-dependencies]
|
|
proptest = "1"
|
|
serde_json = { workspace = true }
|
|
|
|
[dependencies]
|
|
serde = { workspace = true }
|
|
thiserror = { workspace = true }
|
|
klondike = { workspace = true }
|
|
card_game = { workspace = true }
|
|
# Deliberately NOT the workspace rand (0.9): this pins the exact dep the
|
|
# upstream `klondike` crate uses, so `SeedableRng`/`SliceRandom` resolve
|
|
# against the same crate version as `klondike::Rng` and Spider deals go
|
|
# through the identical shuffle stack as Klondike deals.
|
|
rand = { version = "0.10.1", default-features = false, features = ["std_rng"] }
|
|
|
|
[lints]
|
|
workspace = true
|