Remove score_history from GameState #86

New Issue

2026-06-11T03:15:41Z

Quaternions commented

2026-06-11 03:15:41 +00:00

score_history: Vec is vestigial. Undo penalty is correctly tracked in the upstream SessionStats type.

score_history: Vec<i32> is vestigial. Undo penalty is correctly tracked in the upstream SessionStats type.

funman300 commented

2026-06-11 17:37:18 +00:00

Resolved in commit 372b642.

score_history: Vec<i32> is removed, along with its sibling is_recycle_history. These existed as an undo journal for the old hand-rolled score, which was path-dependent (clamped to >=0 at every step) and therefore could not be reconstructed from the move history — the journal was the only way undo() could restore the pre-move score.

With scoring delegated to the upstream session, undo() restores the board via session.undo() and the score is re-derived from session.stats(), so the journal is no longer needed.

Caveat worth recording: upstream does NOT roll back the inner stat counts on undo (it only restores the board + increments undos). A live game's score and the same game reloaded from disk can therefore differ once undos are involved, because the saved forward history excludes undone moves. Accepted as part of the migration.

Resolved in commit 372b642. `score_history: Vec<i32>` is removed, along with its sibling `is_recycle_history`. These existed as an *undo journal* for the old hand-rolled score, which was path-dependent (clamped to >=0 at every step) and therefore could not be reconstructed from the move history — the journal was the only way `undo()` could restore the pre-move score. With scoring delegated to the upstream session, `undo()` restores the board via `session.undo()` and the score is re-derived from `session.stats()`, so the journal is no longer needed. Caveat worth recording: upstream does NOT roll back the inner stat counts on undo (it only restores the board + increments `undos`). A live game's score and the same game reloaded from disk can therefore differ once undos are involved, because the saved forward history excludes undone moves. Accepted as part of the migration.

funman300 closed this issue

2026-06-11 17:37:19 +00:00

funman300 referenced this issue from a commit

2026-06-11 17:49:22 +00:00

refactor(core): derive score/undo/recycle from upstream session stats

funman300 referenced this issue

2026-06-11 17:51:14 +00:00

refactor(core): card_game redundancy cleanup + derive scoring from upstream stats #88

Sign in to join this conversation.