funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 28 Wiki Activity

[critical] Space/D keys fire DrawRequestEvent during replay playback #8

New Issue
Closed
opened 2026-05-19 18:42:00 +00:00 by funman300 · 0 comments
funman300 commented 2026-05-19 18:42:00 +00:00
Owner
Copy Link
Copy Source

File

solitaire_engine/src/input_plugin.rs lines 241–244

Description

handle_keyboard_core emits DrawRequestEvent on Space (and the D-key draw path) with no guard for active replay playback. handle_pause_keyboard in replay_overlay.rs handles the same Space key to toggle pause — both systems run in the same Update schedule with no ordering between them.

Pressing Space during a replay simultaneously toggles the pause state and fires a DrawRequestEvent into handle_draw, which mutates GameStateResource. This breaks replay determinism — the recorded move sequence diverges from what the engine is executing.

Fix

Add if replay_state.is_some_and(|s| s.is_active()) { return; } at the top of handle_keyboard_core, or gate the draw path on replay not being active.

## File `solitaire_engine/src/input_plugin.rs` lines 241–244 ## Description `handle_keyboard_core` emits `DrawRequestEvent` on `Space` (and the D-key draw path) with no guard for active replay playback. `handle_pause_keyboard` in `replay_overlay.rs` handles the same `Space` key to toggle pause — both systems run in the same `Update` schedule with no ordering between them. Pressing `Space` during a replay simultaneously toggles the pause state **and** fires a `DrawRequestEvent` into `handle_draw`, which mutates `GameStateResource`. This breaks replay determinism — the recorded move sequence diverges from what the engine is executing. ## Fix Add `if replay_state.is_some_and(|s| s.is_active()) { return; }` at the top of `handle_keyboard_core`, or gate the draw path on replay not being active.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#8
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?