funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 29 Wiki Activity

Audit animation and timer systems for reactive render compatibility #79

New Issue
Closed
opened 2026-05-29 20:11:57 +00:00 by funman300 · 1 comment
funman300 commented 2026-05-29 20:11:57 +00:00
Owner
Copy Link
Copy Source

Context

Depends on #78 (render-on-demand). Before switching focused_mode to UpdateMode::reactive_low_power, every system that drives continuous visual change must explicitly request a redraw each frame it is active. Otherwise those visuals will freeze.

Systems to audit

System File Risk
Card slide / settle animations card_animation_plugin.rs High — runs many frames per move
Feedback flash animations feedback_anim.rs Medium — short-lived
Auto-complete step ticker auto_complete_plugin.rs High — continuous during auto-complete
Elapsed-time HUD ticker game_plugin.rs::tick_elapsed_time Medium — fires every second
Score tween (if any) hud_plugin.rs Low

Work required

For each system above:

  1. Confirm whether it drives per-frame visual change.
  2. If yes, add window.request_redraw() (via EventWriter<RequestRedraw> or the Window component) each frame the system is actively animating.
  3. Systems that are idle (no animation running) should do nothing — the reactive scheduler will suppress the frame automatically.

Acceptance criteria

  • All animations play at full framerate under UpdateMode::reactive_low_power.
  • cargo test --workspace still passes.
  • Verified on Android device (or emulator) that the board is static between inputs with zero GPU activity.

Labels

  • enhancement
  • android
  • performance
## Context Depends on #78 (render-on-demand). Before switching `focused_mode` to `UpdateMode::reactive_low_power`, every system that drives continuous visual change must explicitly request a redraw each frame it is active. Otherwise those visuals will freeze. ## Systems to audit | System | File | Risk | |---|---|---| | Card slide / settle animations | `card_animation_plugin.rs` | High — runs many frames per move | | Feedback flash animations | `feedback_anim.rs` | Medium — short-lived | | Auto-complete step ticker | `auto_complete_plugin.rs` | High — continuous during auto-complete | | Elapsed-time HUD ticker | `game_plugin.rs::tick_elapsed_time` | Medium — fires every second | | Score tween (if any) | `hud_plugin.rs` | Low | ## Work required For each system above: 1. Confirm whether it drives per-frame visual change. 2. If yes, add `window.request_redraw()` (via `EventWriter<RequestRedraw>` or the `Window` component) each frame the system is actively animating. 3. Systems that are idle (no animation running) should do nothing — the reactive scheduler will suppress the frame automatically. ## Acceptance criteria - All animations play at full framerate under `UpdateMode::reactive_low_power`. - `cargo test --workspace` still passes. - Verified on Android device (or emulator) that the board is static between inputs with zero GPU activity. ## Labels - enhancement - android - performance
funman300 commented 2026-05-29 20:55:43 +00:00
Author
Owner
Copy Link
Copy Source

Fixed in 38e4c03.

All per-frame animation systems now write RequestRedraw each frame they have active work:

  • advance_card_animations (card slide)
  • advance_card_anims (deal / win cascade)
  • tick_shake_anim, tick_settle_anim, tick_foundation_flourish
  • drive_toast_display (toast countdown)
  • drive_auto_complete (step interval keepalive)

Each plugin also registers add_message::<RequestRedraw>() so tests under MinimalPlugins continue to pass. #78 switched focused_mode to reactive_low_power(100 ms) on top of this.

Fixed in 38e4c03. All per-frame animation systems now write `RequestRedraw` each frame they have active work: - `advance_card_animations` (card slide) - `advance_card_anims` (deal / win cascade) - `tick_shake_anim`, `tick_settle_anim`, `tick_foundation_flourish` - `drive_toast_display` (toast countdown) - `drive_auto_complete` (step interval keepalive) Each plugin also registers `add_message::<RequestRedraw>()` so tests under `MinimalPlugins` continue to pass. #78 switched `focused_mode` to `reactive_low_power(100 ms)` on top of this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
bug
correctness
enhancement
performance
security
server
test
ui
ux
wasm
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#79
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?