funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 14 Pull Requests Actions Packages Projects Releases 28 Wiki Activity

bug(settings): default theme ID 'classic' contradicts migration that renames it to 'dark' #64

New Issue
Open
opened 2026-05-28 01:51:33 +00:00 by funman300 · 0 comments
funman300 commented 2026-05-28 01:51:33 +00:00
Owner
Copy Link
Copy Source

Bug

settings.rs sets the default theme ID to "classic". However, the settings migration logic renames the old "classic" theme to "dark" for existing users. New installs therefore start with a theme ID that does not match any installed theme, falling back to the system default silently.

Affected files

  • solitaire_engine/src/settings.rs (default value)
  • Settings migration code (rename logic)

Fix

Either:

  • Change the default in settings.rs to "dark" to match the post-migration name, or
  • Keep a "classic" theme variant and ensure the migration only applies to users upgrading from old versions

Document which theme IDs are canonical in ARCHITECTURE.md or a comment.

## Bug `settings.rs` sets the default theme ID to `"classic"`. However, the settings migration logic renames the old `"classic"` theme to `"dark"` for existing users. New installs therefore start with a theme ID that does not match any installed theme, falling back to the system default silently. ## Affected files - `solitaire_engine/src/settings.rs` (default value) - Settings migration code (rename logic) ## Fix Either: - Change the default in `settings.rs` to `"dark"` to match the post-migration name, **or** - Keep a `"classic"` theme variant and ensure the migration only applies to users upgrading from old versions Document which theme IDs are canonical in `ARCHITECTURE.md` or a comment.
funman300 added the bugcorrectness labels 2026-05-28 01:51:33 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
bug
correctness
performance
security
server
test
ui
wasm
No Label bug correctness
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#64
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?