funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 48 Wiki Activity

bug(ui): profile panel can stack over other modals — missing ModalScrim guard #57

New Issue
Closed
opened 2026-05-28 01:50:32 +00:00 by funman300 · 0 comments
funman300 commented 2026-05-28 01:50:32 +00:00
Owner
Copy Link
Copy Source

Bug

profile_plugin.rs spawns a modal overlay without first checking whether a ModalScrim already exists. This means the Profile panel can be layered on top of an already-open Settings, Help, or Sync panel, breaking the modal stack.

Affected file

solitaire_engine/src/profile_plugin.rs

Fix

Add the standard guard before spawning (per CLAUDE.md §14.2):

fn open_profile(
    mut commands: Commands,
    scrims: Query<(), With<ModalScrim>>,
    // ...
) {
    // ... spawn_modal(...)
}

Relevant rule

CLAUDE.md §11: spawning a second ModalScrim while one already exists without first dismissing the existing one

## Bug `profile_plugin.rs` spawns a modal overlay without first checking whether a `ModalScrim` already exists. This means the Profile panel can be layered on top of an already-open Settings, Help, or Sync panel, breaking the modal stack. ## Affected file `solitaire_engine/src/profile_plugin.rs` ## Fix Add the standard guard before spawning (per CLAUDE.md §14.2): ```rust fn open_profile( mut commands: Commands, scrims: Query<(), With<ModalScrim>>, // ... ) { // ... spawn_modal(...) } ``` ## Relevant rule CLAUDE.md §11: *spawning a second ModalScrim while one already exists without first dismissing the existing one*
funman300 added the bugui labels 2026-05-28 01:50:32 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
bug
correctness
enhancement
performance
security
server
test
ui
ux
wasm
No Label bug ui
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#57
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?