funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 48 Wiki Activity

bug(time-attack): timer does not pause when Home or Win overlay is open #54

New Issue
Closed
opened 2026-05-28 01:48:59 +00:00 by funman300 · 0 comments
funman300 commented 2026-05-28 01:48:59 +00:00
Owner
Copy Link
Copy Source

Bug

In time_attack_plugin.rs, the countdown timer only stops when the game's paused resource has paused.is_some_and(|p| p.0). Opening the Home menu or the Win overlay sets a different state and does not set this pause flag, so the timer continues to count down while the overlay is visible.

Affected file

solitaire_engine/src/time_attack_plugin.rs

Expected behaviour

The timer should pause whenever any full-screen overlay (Home, Win summary, Settings, etc.) is open, not only when the explicit pause flag is set.

Fix

Check GameState / screen state in the timer update system and return early when any modal or overlay is active, OR hook into the same system that pauses background systems during overlays.

## Bug In `time_attack_plugin.rs`, the countdown timer only stops when the game's `paused` resource has `paused.is_some_and(|p| p.0)`. Opening the Home menu or the Win overlay sets a different state and does not set this pause flag, so the timer continues to count down while the overlay is visible. ## Affected file `solitaire_engine/src/time_attack_plugin.rs` ## Expected behaviour The timer should pause whenever any full-screen overlay (Home, Win summary, Settings, etc.) is open, not only when the explicit pause flag is set. ## Fix Check `GameState` / screen state in the timer update system and return early when any modal or overlay is active, OR hook into the same system that pauses background systems during overlays.
funman300 added the bugcorrectness labels 2026-05-28 01:48:59 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
android
bug
correctness
enhancement
performance
security
server
test
ui
ux
wasm
No Label bug correctness
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#54
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?