funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 28 Wiki Activity

expect() in Startup system and TokioRuntimeResource::default() violate no-panic rule #33

New Issue
Closed
opened 2026-05-19 18:44:36 +00:00 by funman300 · 0 comments
funman300 commented 2026-05-19 18:44:36 +00:00
Owner
Copy Link
Copy Source

Files

  • solitaire_engine/src/font_plugin.rs line 35
  • solitaire_engine/src/resources.rs line 141

Description

Two expect() calls in non-test runtime code violate CLAUDE.md §2.3:

  1. Font::try_from_bytes(...).expect("bundled FiraMono failed to parse") — a corrupted binary or storage error at startup panics the process instead of degrading gracefully.
  2. TokioRuntimeResource::default() calls .expect("failed to build shared Tokio runtime") — on Android, the OS can refuse thread creation under memory pressure, panicking the main thread during plugin setup.

Fix

Replace both with match/? propagation that logs the error and either falls back to a default handle or disables the dependent feature, consistent with the pattern used elsewhere in the engine.

## Files - `solitaire_engine/src/font_plugin.rs` line 35 - `solitaire_engine/src/resources.rs` line 141 ## Description Two `expect()` calls in non-test runtime code violate CLAUDE.md §2.3: 1. `Font::try_from_bytes(...).expect("bundled FiraMono failed to parse")` — a corrupted binary or storage error at startup panics the process instead of degrading gracefully. 2. `TokioRuntimeResource::default()` calls `.expect("failed to build shared Tokio runtime")` — on Android, the OS can refuse thread creation under memory pressure, panicking the main thread during plugin setup. ## Fix Replace both with `match`/`?` propagation that logs the error and either falls back to a default handle or disables the dependent feature, consistent with the pattern used elsewhere in the engine.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#33
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?