funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 28 Wiki Activity

evaluate_on_win uses .last() — drops all but the final GameWonEvent when multiple fire in one frame #29

New Issue
Closed
opened 2026-05-19 18:44:35 +00:00 by funman300 · 0 comments
funman300 commented 2026-05-19 18:44:35 +00:00
Owner
Copy Link
Copy Source

File

solitaire_engine/src/achievement_plugin.rs line 165

Description

wins.read().last() only processes the final GameWonEvent per frame. If multiple events arrive (e.g. integration tests, replaying quickly), earlier wins in the same frame skip achievement evaluation entirely. This is inconsistent with progress_plugin.rs:award_xp_on_win, which correctly iterates for ev in wins.read().

Fix

Change to for ev in wins.read() { ... } to handle every win event, matching the pattern in progress_plugin.rs.

## File `solitaire_engine/src/achievement_plugin.rs` line 165 ## Description `wins.read().last()` only processes the final `GameWonEvent` per frame. If multiple events arrive (e.g. integration tests, replaying quickly), earlier wins in the same frame skip achievement evaluation entirely. This is inconsistent with `progress_plugin.rs:award_xp_on_win`, which correctly iterates `for ev in wins.read()`. ## Fix Change to `for ev in wins.read() { ... }` to handle every win event, matching the pattern in `progress_plugin.rs`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#29
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?