drop_overlay_rect panics via HashMap index operator on unknown PileType #26

New Issue

2026-05-19T18:44:35Z

funman300 commented

2026-05-19 18:44:35 +00:00

File

solitaire_engine/src/cursor_plugin.rs line 388

Description

layout.pile_positions[pile] uses the Index trait on HashMap<PileType, Vec2>, which panics if the key is absent. This violates CLAUDE.md §2.3 (no unwrap() / panic!() in runtime game logic). While compute_layout is expected to populate all pile positions, this is an implicit runtime invariant — any future pile variant added without updating compute_layout would produce an unrecoverable panic during a drag operation.

Fix

Replace with layout.pile_positions.get(pile).copied().unwrap_or_default() or log a warning and return a fallback rect.

## File `solitaire_engine/src/cursor_plugin.rs` line 388 ## Description `layout.pile_positions[pile]` uses the `Index` trait on `HashMap<PileType, Vec2>`, which panics if the key is absent. This violates CLAUDE.md §2.3 (no `unwrap()` / `panic!()` in runtime game logic). While `compute_layout` is expected to populate all pile positions, this is an implicit runtime invariant — any future pile variant added without updating `compute_layout` would produce an unrecoverable panic during a drag operation. ## Fix Replace with `layout.pile_positions.get(pile).copied().unwrap_or_default()` or log a warning and return a fallback rect.

funman300 referenced this issue from a commit

2026-05-19 20:15:26 +00:00

fix(multi): resolve 26 bugs found in comprehensive codebase review

funman300 closed this issue

2026-05-19 20:20:22 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#26