SyncAuthError and SyncBusyOverlay on same entity — auth error text is always invisible #20

New Issue

2026-05-19T18:43:05Z

funman300 commented

2026-05-19 18:43:05 +00:00

File

solitaire_engine/src/sync_setup_plugin.rs lines 684–691 (spawn), 416–418 (poll)

Description

The status line node is spawned with both SyncAuthError and SyncBusyOverlay components on the same entity. In poll_auth_task, on both success and error paths, the first operation is:

for mut vis in &mut busy_nodes {  // matches With<SyncBusyOverlay>
    *vis = Visibility::Hidden;
}

This hides the entity before the error text is written to it. The player never sees the error message — the entity is always invisible when errors occur.

Fix

Use two separate child entities: one bearing only SyncBusyOverlay (hidden on task completion), and one bearing only SyncAuthError (set to Visible when an error occurs).

## File `solitaire_engine/src/sync_setup_plugin.rs` lines 684–691 (spawn), 416–418 (poll) ## Description The status line node is spawned with **both** `SyncAuthError` and `SyncBusyOverlay` components on the same entity. In `poll_auth_task`, on both success and error paths, the first operation is: ```rust for mut vis in &mut busy_nodes { // matches With<SyncBusyOverlay> *vis = Visibility::Hidden; } ``` This hides the entity before the error text is written to it. The player never sees the error message — the entity is always invisible when errors occur. ## Fix Use two separate child entities: one bearing only `SyncBusyOverlay` (hidden on task completion), and one bearing only `SyncAuthError` (set to `Visible` when an error occurs).

funman300 referenced this issue from a commit

2026-05-19 20:15:26 +00:00

fix(multi): resolve 26 bugs found in comprehensive codebase review

funman300 closed this issue

2026-05-19 20:20:21 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#20