Time attack countdown continues running while Win Summary overlay is displayed #17

New Issue

2026-05-19T18:43:04Z

funman300 commented

2026-05-19 18:43:04 +00:00

File

solitaire_engine/src/time_attack_plugin.rs lines 168–198

Description

advance_time_attack halts the countdown when PausedResource is true or HomeScreen is open, but has no check for WinSummaryOverlay. When a Time Attack game is won, the 0.5-second delay before the win modal spawns means the timer is already burning. More importantly, the timer continues draining while the player reads the "You Won!" modal.

The analogous tick_elapsed_time system in game_plugin correctly stops on game.0.is_won; advance_time_attack has no equivalent check.

Fix

Add an is_won or WinSummaryOverlay existence check to the advance_time_attack guard conditions.

## File `solitaire_engine/src/time_attack_plugin.rs` lines 168–198 ## Description `advance_time_attack` halts the countdown when `PausedResource` is true or `HomeScreen` is open, but has no check for `WinSummaryOverlay`. When a Time Attack game is won, the 0.5-second delay before the win modal spawns means the timer is already burning. More importantly, the timer continues draining while the player reads the "You Won!" modal. The analogous `tick_elapsed_time` system in `game_plugin` correctly stops on `game.0.is_won`; `advance_time_attack` has no equivalent check. ## Fix Add an `is_won` or `WinSummaryOverlay` existence check to the `advance_time_attack` guard conditions.

funman300 referenced this issue from a commit

2026-05-19 20:15:26 +00:00

fix(multi): resolve 26 bugs found in comprehensive codebase review

funman300 closed this issue

2026-05-19 20:20:21 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#17