chore: delete dead code approved from the PR #166 sweep #169

2026-07-09T20:28:22Z

funman300 commented

2026-07-09 20:28:22 +00:00

Removes the three items the PR #166 dead-code sweep left pending user decision (all approved):

WinCascadePlugin — never registered anywhere; handle_win_cascade in AnimationPlugin is the live win cascade and builds its scatter targets inline. The plugin's helpers (win_scatter_targets, cascade_delay, WIN_CASCADE_INTERVAL_SECS) had no remaining callers outside their own tests, so they go with it.
SyncCompleteEvent — written twice by the pull-completion system, read by nothing (UI polls SyncStatusResource). Removed the event, its registration, and both write sites; the merged-state persistence and status updates are unchanged.
solitaire_sync::ApiError — serialized by neither client nor server. Also dropped the merge_at crate-root re-export (merge::merge_at itself stays; merge uses it internally).

ARCHITECTURE.md updated (crate inventory, sync-flow diagram, event list). Net −202 lines.

cargo test --workspace and cargo clippy --workspace -- -D warnings are clean.

🤖 Generated with Claude Code

Removes the three items the PR #166 dead-code sweep left pending user decision (all approved): - **`WinCascadePlugin`** — never registered anywhere; `handle_win_cascade` in `AnimationPlugin` is the live win cascade and builds its scatter targets inline. The plugin's helpers (`win_scatter_targets`, `cascade_delay`, `WIN_CASCADE_INTERVAL_SECS`) had no remaining callers outside their own tests, so they go with it. - **`SyncCompleteEvent`** — written twice by the pull-completion system, read by nothing (UI polls `SyncStatusResource`). Removed the event, its registration, and both write sites; the merged-state persistence and status updates are unchanged. - **`solitaire_sync::ApiError`** — serialized by neither client nor server. Also dropped the `merge_at` crate-root re-export (`merge::merge_at` itself stays; `merge` uses it internally). ARCHITECTURE.md updated (crate inventory, sync-flow diagram, event list). Net −202 lines. `cargo test --workspace` and `cargo clippy --workspace -- -D warnings` are clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

funman300 added 1 commit 2026-07-09 20:28:23 +00:00

chore: delete dead code approved from the PR #166 sweep

Test / test (pull_request) Failing after 18s

Details

b26200f948

Three items the multi-agent sweep flagged, now removed with user
approval (§8 for the solitaire_sync changes):

- WinCascadePlugin: never registered; handle_win_cascade in
  AnimationPlugin is the live win cascade and builds its own targets.
  Its now-orphaned helpers (win_scatter_targets, cascade_delay,
  WIN_CASCADE_INTERVAL_SECS) had no callers outside their own tests
  and go with it.
- SyncCompleteEvent: written by the pull-completion system, zero
  readers — UI reads SyncStatusResource instead.
- solitaire_sync::ApiError: unused by client and server; the merge_at
  crate-root re-export goes too (merge::merge_at stays for the merge
  module's own use).

ARCHITECTURE.md updated to match.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

funman300 added 2 commits 2026-07-09 22:02:18 +00:00

Merge remote-tracking branch 'origin/master' into chore/dead-code-removals 48f0907f78

chore(engine): apply rustfmt after dead-code removals

Test / test (pull_request) Successful in 35m45s

Details

8d80f95bd0

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

funman300 merged commit fce0266b47 into master

2026-07-09 23:46:47 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#169