funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 48 Wiki Activity

refactor(engine): ambiguity burn-down batch 2 — SettingsResource cleared (198 → 171) #147

Merged
funman300 merged 1 commits from refactor/ambiguity-settings into master 2026-07-07 03:48:11 +00:00
Conversation 0 Commits 1 Files Changed 6
+38 -6
funman300 commented 2026-07-07 03:48:10 +00:00
Owner
Copy Link
Copy Source

Batch 2 of #143: SettingsMutation set mirroring the game-state spine — mutator chain before GameMutation, readers after (mostly transitively). SettingsResource pairs: 21 → 0; baseline ratchets 198 → 171.

Gates: ratchet green at 171, workspace clippy --all-targets -D warnings clean, full suite green.

Refs #143

🤖 Generated with Claude Code

Batch 2 of #143: `SettingsMutation` set mirroring the game-state spine — mutator chain before `GameMutation`, readers after (mostly transitively). **SettingsResource pairs: 21 → 0**; baseline ratchets **198 → 171**. Gates: ratchet green at 171, workspace clippy `--all-targets -D warnings` clean, full suite green. Refs #143 🤖 Generated with [Claude Code](https://claude.com/claude-code)
funman300 added 1 commit 2026-07-07 03:48:10 +00:00
refactor(engine): ambiguity burn-down batch 2 — SettingsResource cleared, 198 → 171
Test / test (pull_request) Successful in 28m7s
Details
58c2dfd0a9 
New SettingsMutation set: the per-frame settings mutators
(handle_volume_keys → record_window_geometry_changes →
persist_window_geometry_after_debounce) run as a deterministic chain
ordered before GameMutation, so every reader already after GameMutation
observes the current frame's settings transitively. The four readers
outside that ordering (modal enter-speed chain, focus-ring pulse, HUD
avatar, and the game plugin's pre-mutation chain) are ordered after the
set explicitly.

SettingsResource ambiguities: 21 → 0. Baseline ratchets 198 → 171.

Refs #143

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
funman300 merged commit 713a292057 into master 2026-07-07 03:48:11 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
android
bug
correctness
enhancement
performance
security
server
test
ui
ux
wasm
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#147
Delete Branch "refactor/ambiguity-settings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?