funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 48 Wiki Activity

fix(engine): raise dynamic tableau fan cap to fill tall viewports #115

Merged
funman300 merged 1 commits from fix/cover-screen-fan-cap into master 2026-06-26 21:15:54 +00:00
Conversation 0 Commits 1 Files Changed 2
+12 -14
funman300 commented 2026-06-26 21:15:53 +00:00
Owner
Copy Link
Copy Source

Raises MAX_DYNAMIC_FAN_FRAC 0.6 → 0.9 so the dynamic tableau fill spreads further on very tall / narrow viewports (a foldable cover screen was left ~40% empty at the cap). Fills the unfolded near-square screen to ~100%, lets the cover screen fill further, and the rest fills as columns deepen during play. Normal phones are unaffected (their fill fraction is already below the cap); deeper columns still drive the fraction down so nothing overflows, and hit-testing stays in sync.

Vertical centring of the residual was investigated and dropped: a 21:9 phone is aspect-identical to the cover screen, so centring can't be targeted to foldables without disconnecting the board from the HUD on tall phones.

🤖 Generated with Claude Code

Raises `MAX_DYNAMIC_FAN_FRAC` 0.6 → 0.9 so the dynamic tableau fill spreads further on very tall / narrow viewports (a foldable **cover screen** was left ~40% empty at the cap). Fills the unfolded near-square screen to ~100%, lets the cover screen fill further, and the rest fills as columns deepen during play. Normal phones are unaffected (their fill fraction is already below the cap); deeper columns still drive the fraction down so nothing overflows, and hit-testing stays in sync. Vertical centring of the residual was investigated and dropped: a 21:9 phone is aspect-identical to the cover screen, so centring can't be targeted to foldables without disconnecting the board from the HUD on tall phones. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
funman300 added 1 commit 2026-06-26 21:15:53 +00:00
fix(engine): raise dynamic tableau fan cap to fill tall viewports 94a6feb5db 
MAX_DYNAMIC_FAN_FRAC 0.6 -> 0.9 so the dynamic tableau fill spreads
further on very tall / narrow viewports (e.g. a foldable cover screen),
which were left ~40% empty at the cap. Fills the unfolded near-square
screen to ~100% and lets the cover screen fill further (and the rest fills
as columns deepen during play). Normal phones are unaffected — their fill
fraction is already below the cap. apply_dynamic_tableau_fan still floors
at TABLEAU_FAN_FRAC and deeper columns drive the fraction down, so nothing
overflows and hit-testing stays in sync.

Vertical centring of the residual was investigated but dropped: a 21:9
phone is aspect-identical to the cover screen, so centring can't be
targeted to foldables without also disconnecting the board from the HUD on
tall phones.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
funman300 merged commit 783f01628e into master 2026-06-26 21:15:54 +00:00
funman300 deleted branch fix/cover-screen-fan-cap 2026-06-26 21:15:54 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
android
bug
correctness
enhancement
performance
security
server
test
ui
ux
wasm
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#115
Delete Branch "fix/cover-screen-fan-cap"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?