funman300/Ferrous-Solitaire
1
1
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 48 Wiki Activity

fix(engine): clicking the waste card no longer draws from stock #104

Merged
funman300 merged 1 commits from fix/waste-click-draws into master 2026-06-24 17:31:31 +00:00
Conversation 0 Commits 1 Files Changed 1
+9 -9
funman300 commented 2026-06-24 17:31:22 +00:00
Owner
Copy Link
Copy Source

Reported on /play: clicking the drawn card just draws the next one instead of letting you move it.

Cause: handle_stock_click (and handle_touch_stock_tap) hit-tested both the deck AND the waste slot, so a click on the waste card fired DrawRequestEvent — and it swallowed the first click of a double-click, so double-click-to-auto-move never fired on the waste either.

Fix: only the face-down deck draws. The waste card is now free to play (double-click/double-tap to auto-move, or drag).

wasm-feeding change -> web-wasm-rebuild regenerates canvas_bg.wasm and redeploys /play after merge.

Reported on /play: clicking the drawn card just draws the next one instead of letting you move it. Cause: handle_stock_click (and handle_touch_stock_tap) hit-tested both the deck AND the waste slot, so a click on the waste card fired DrawRequestEvent — and it swallowed the first click of a double-click, so double-click-to-auto-move never fired on the waste either. Fix: only the face-down deck draws. The waste card is now free to play (double-click/double-tap to auto-move, or drag). wasm-feeding change -> web-wasm-rebuild regenerates canvas_bg.wasm and redeploys /play after merge.
funman300 added 1 commit 2026-06-24 17:31:22 +00:00
fix(engine): clicking the waste card no longer draws from stock f88b6f61d0 
handle_stock_click (and handle_touch_stock_tap) hit-tested both the face-down
deck AND the waste slot, so a click/tap on the drawn waste card fired
DrawRequestEvent — drawing the next card instead of playing the waste card, and
swallowing the first click of a double-click so auto-move never triggered.

Only the deck draws now. The waste card is left free to play: double-click /
double-tap to auto-move, or drag it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
funman300 merged commit 7919365775 into master 2026-06-24 17:31:31 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
android
bug
correctness
enhancement
performance
security
server
test
ui
ux
wasm
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
funman300 (Alex)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: funman300/Ferrous-Solitaire#104
Delete Branch "fix/waste-click-draws"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?