- Approach: note Quaternions is addressing gaps 1 and 4 upstream
(card_game issues #10 and #11)
- Gap 1: replace comparison table with exact WXP scoring table from
solitaire_core/src/scoring.rs; add solitaireparadise.com reference;
note time bonus stays in adapter (not wasm-portable)
- Gap 2: expand mode table with full Scoring + Undo columns; add
descriptions for Zen (relaxed, score = 0) and Challenge (timed
daily puzzle, undo disabled)
- Gap 4: clarify the flag *enables* an optional move (off by default),
not disables; link upstream issue #11
- Gap 5: note Quaternions confirmed newtypes approach, no upstream
changes needed
- Gap 6: document that MoveError is generated at instruction-
construction boundary in solitaire_core, not by wrapping
is_instruction_valid's bool
- Gap 8: mark resolved; 0.02 ms worst case at 1M moves/s; drop
snapshot ring-buffer plan
- Integration path: updated steps to reflect resolved gaps and
upstream issue dependencies
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Reframe the integration approach: klondike is a read-only dependency;
all 8 gaps (scoring, game modes, solver, take_from_foundation, serde,
MoveError, waste pile, undo stack) are closed in solitaire_core via a
KlondikeAdapter wrapper layer. No upstream changes to card_game or
klondike are required.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Documents what Quaternions/card_game already provides, what
solitaire_core requires that is currently missing, and the
suggested step-by-step integration path.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
funman300