chore: add pedantic workspace lints (#90)

Add [workspace.lints.rust] and wire each member crate up with
[lints] workspace = true:

  unsafe_code = "deny"        (forbid would break the Android JNI build)
  single_use_lifetimes = "warn"
  trivial_casts = "warn"
  unused_lifetimes = "warn"
  unused_qualifications = "warn"
  variant_size_differences = "warn"
  unexpected_cfgs = "warn"

unsafe_code is "deny" rather than the issue's "forbid" so the three
Android JNI FFI modules (android_keystore, android_clipboard, safe_area)
can opt back in with a scoped #![allow(unsafe_code)] — forbid cannot be
locally overridden. Pure crates carry no unsafe and stay clean.

Clean up the warnings the new lints surface:
- 150ish unused_qualifications removed via `cargo fix` (purely syntactic
  redundant-path-prefix removals).
- table_plugin: the TABLE_COLOUR import was #[cfg(test)]-gated while the
  camera clear-colour used the fully-qualified path; unqualifying it left
  a non-test build with no import. Made the import unconditional instead.
- assets/sources: the `as &[u8]` casts in embed_*_svg! coerce each
  fixed-size &[u8; N] to a uniform slice so the tuples fit the
  &[(&str, &[u8])] arrays — load-bearing, so scoped #[allow(trivial_casts)].

Workspace clippy -D warnings and the full test suite pass. Android build
not compiled here (needs the NDK; built separately per CLAUDE.md §15) —
the deny + scoped-allow keeps the JNI unsafe blocks legal.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

This commit is contained in:

funman300

2026-06-12 13:05:28 -07:00

parent 9bbb57134f

commit ceb9c950a1

48 changed files with 191 additions and 130 deletions

									
										solitaire_engine/src/theme/plugin.rs
									
		+1
		-1
	
												View File
												
				@@ -484,7 +484,7 @@ mod tests {

				        let mut image_set = empty_card_image_set();

				        // Snapshot the legacy back ids so we can prove they don't

				        // change when a theme is applied.

				        let legacy_ids_before: [bevy::asset::AssetId<bevy::image::Image>; 5] =

				        let legacy_ids_before: [AssetId<Image>; 5] =

				            std::array::from_fn(|i| image_set.backs[i].id());

				        let theme = empty_theme();

				        assert!(image_set.theme_back.is_none(), "theme_back starts empty");