fix(android): A2/A3/A4 — APK build doc, dead refs, modal hit targets
A2: docs/ANDROID.md — remove stale "permanent fix to come" note;
clarify --lib is the canonical command; root-cause the upstream
cargo-apk bug. SESSION_HANDOFF.md closes the open item.
A3: Remove dead CARD_PLAN.md references from four source module
doc comments (theme/importer.rs, theme/plugin.rs, assets/mod.rs,
assets/svg_loader.rs). Also fix stale "future picker UI" language
in plugin.rs (picker shipped in Phase 7).
A4: ui_modal.rs spawn_modal_button — add min_height: Val::Px(48.0)
so every modal action button meets Material's 48 dp touch target
minimum. Modal button height was 42 px (2×SPACE_3 + TYPE_BODY_LG);
now clamped to 48 px minimum. Cards at 40 dp on 360 dp phones are
layout-constrained (7 columns) and cannot be widened.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -1,10 +1,8 @@
|
||||
//! Asset-loading infrastructure for runtime SVG rasterisation and the
|
||||
//! per-platform user-themes directory.
|
||||
//!
|
||||
//! See `CARD_PLAN.md` for the full multi-phase implementation plan.
|
||||
//! This module is the entry point for Phases 1 (SVG → `Image`) and 5
|
||||
//! (user-themes directory). Phase 3 will extend it further with custom
|
||||
//! `AssetSource` implementations for `embedded://` and `themes://`.
|
||||
//! Provides the SVG → `Image` loader and the `embedded://` / `themes://`
|
||||
//! custom `AssetSource` implementations used by the theme system.
|
||||
|
||||
pub mod card_face_svg;
|
||||
pub mod icon_svg;
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
//! Bevy `AssetLoader` that rasterises an SVG into `bevy::image::Image`.
|
||||
//!
|
||||
//! The card-theme system (see `CARD_PLAN.md`) ships SVG sources both as
|
||||
//! The card-theme system ships SVG sources both as
|
||||
//! the embedded default theme and as user-supplied themes. Bevy 0.18 has
|
||||
//! no built-in SVG support, so this loader bridges `usvg` (parser) +
|
||||
//! `resvg` (renderer) + `tiny-skia` (CPU pixmap) to produce textures
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
//! Theme zip-archive importer.
|
||||
//!
|
||||
//! Phase 7 of the card-theme system (see `CARD_PLAN.md`). Players ship
|
||||
//! Players ship
|
||||
//! and install third-party themes as a single `.zip` containing a
|
||||
//! `theme.ron` manifest at the archive root plus the 52 face SVGs and
|
||||
//! one back SVG referenced by that manifest. [`import_theme`] is the
|
||||
|
||||
@@ -3,10 +3,8 @@
|
||||
//! with the currently-loaded theme so existing card-rendering systems
|
||||
//! pick up the new artwork on the next state-changed tick.
|
||||
//!
|
||||
//! Phase 4 of `CARD_PLAN.md`. The plugin's `set_theme` helper is the
|
||||
//! public API that the future picker UI (Phase 6) calls; for now it's
|
||||
//! exposed for tests and for any embedder that wants to load an
|
||||
//! alternative theme manually.
|
||||
//! The plugin's `set_theme` helper is the public API used by the
|
||||
//! Settings appearance picker and exposed for tests.
|
||||
|
||||
use std::collections::HashMap;
|
||||
|
||||
|
||||
@@ -372,6 +372,7 @@ pub fn spawn_modal_button<M: Component>(
|
||||
Button,
|
||||
Node {
|
||||
padding: UiRect::axes(VAL_SPACE_4, VAL_SPACE_3),
|
||||
min_height: Val::Px(48.0),
|
||||
justify_content: JustifyContent::Center,
|
||||
align_items: AlignItems::Center,
|
||||
column_gap: VAL_SPACE_2,
|
||||
|
||||
Reference in New Issue
Block a user