Alex funman300
  • Joined on 2026-01-25
funman300 closed issue funman300/Ferrous-Solitaire#90 2026-06-12 20:07:29 +00:00
Add some pedantic lints for fun
ceb9c950a1 chore: add pedantic workspace lints (#90)
funman300 closed issue funman300/Ferrous-Solitaire#89 2026-06-12 19:45:19 +00:00
Remove Saved* serde mirror types (migrate ReplayMove to upstream klondike serde)
9bbb57134f refactor: persist replay/save moves as KlondikeInstruction, not pile coords (#89)
funman300 commented on issue funman300/Ferrous-Solitaire#89 2026-06-12 02:59:19 +00:00
Remove Saved* serde mirror types (migrate ReplayMove to upstream klondike serde)

Unblocked — revised approach (per upstream author). Asked Rhys to add serde to the klondike pile types; his answer: *"It shouldn't need to serialize those for any reason, they are only…

funman300 closed issue funman300/Ferrous-Solitaire#85 2026-06-12 02:50:39 +00:00
Remove TestPileState
funman300 commented on issue funman300/Ferrous-Solitaire#85 2026-06-12 02:48:58 +00:00
Remove TestPileState

Investigated — TestPileState does NOT appear in the final/production types. It's already correctly gated out.

  • test_pile_state is #[cfg(feature = "test-support")], and test-support is…
e0a858d4e8 refactor: remove card.rs / card_to_id; use card_game::Card directly (#83)
5c992cbdca refactor: replace local DrawMode with upstream klondike::DrawStockConfig (#82)
Compare 2 commits »
funman300 closed issue funman300/Ferrous-Solitaire#82 2026-06-12 02:36:06 +00:00
Remove DrawMode
funman300 commented on issue funman300/Ferrous-Solitaire#82 2026-06-12 02:36:05 +00:00
Remove DrawMode

Resolved in commit 5c992cb. Local DrawMode replaced by upstream klondike::DrawStockConfig everywhere (278 refs across all crates); re-exported from solitaire_core. Serde is unchanged (same…

funman300 commented on issue funman300/Ferrous-Solitaire#83 2026-06-12 02:35:16 +00:00
Remove card.rs

Resolved in commit e0a858d (branch refactor/strip-card_game-redundancies).

card_to_id (the 0..=51 frankenstein id) is removed and card.rs deleted. Replacements:

  • feedback_anim deal…
funman300 closed issue funman300/Ferrous-Solitaire#83 2026-06-12 02:35:16 +00:00
Remove card.rs
funman300 commented on issue funman300/Ferrous-Solitaire#89 2026-06-12 01:56:35 +00:00
Remove Saved* serde mirror types (migrate ReplayMove to upstream klondike serde)

Investigated — this issue's premise is wrong; the Saved pile mirrors are NOT removable.* A multi-agent attempt was reverted after the build proved it.

Root cause: upstream klondike 0.4.0

funman300 opened issue funman300/Ferrous-Solitaire#89 2026-06-11 22:31:30 +00:00
Remove Saved* serde mirror types (migrate ReplayMove to upstream klondike serde)
d045781119 chore: gitignore .claude-flow scratch dirs
f0871c03e8 chore: gitignore local helper scripts
e841a7ab4f refactor: delete solitaire_data::solver wrapper; solve via card_game directly
Compare 2 commits »
424c8b2d50 perf(engine): route remaining drag card→entity lookups through CardEntityIndex
372b6423d8 refactor(core): derive score/undo/recycle from upstream session stats
funman300 closed issue funman300/Ferrous-Solitaire#87 2026-06-11 17:37:20 +00:00
Remove counts from GameState
funman300 closed issue funman300/Ferrous-Solitaire#84 2026-06-11 17:37:19 +00:00
Remove external undo tracking