Promote the FIFA17 SBC dispatch repair: armed by the build, not by env

Retail Gates A-G passed on the pinned CardsDLL build (4706a881), and the repair
has been live-proven repeatedly, so it is now a promoted feature. Arming it from
OPENFUT_SBC_DISPATCH meant any launch that did not export it (Steam, the launcher
Launch button, a bare umu-run) silently lost the SBC screen to the known
response-to-deserializer dispatch defect, leaving a harness script as the only
working entry point.

REPAIR_PROMOTED is now a build constant with a compile-time contract, and both
install sites derive from it: sbc_dispatch::install always arms, and
sbc_trace::install derives the parser/notifier/controller-registration traces from
it because those traces ARE the repair decision inputs, not optional diagnostics.

Promotion weakens no check. Safety stays in the runtime evidence gate rather than a
flag: the worker still validates the exact CardsDLL signatures before installing a
detour, and decide() still requires the transport sentinel status, the pinned
category-response vtable captured while the response object was provably live,
balanced parser counts on the one parser thread, this generation notifier having
entered AND returned, the captured controller/model identity, and one repair per
deserializer generation. An unrecognised build leaves native execution untouched.

Rollback is a file swap (restore the previous version.dll via the hook harness
backup), the documented client rollback path, deliberately not an env kill-switch.

fmt clean, strict clippy clean on default and fifa17 features, 22 tests pass,
release cross-build to x86_64-pc-windows-gnu produces artifact 3641d581.

This commit is contained in:

funman300

2026-08-19 02:45:43 +00:00

parent c3addde9b1

commit 94feaec63f

3 changed files with 39 additions and 21 deletions

									
										openfut-hook/src/sbc_trace.rs
									
		+3
		-1
	
												View File
												
				@@ -1148,7 +1148,9 @@ fn install_notifier(enabled: bool) {

				}

				pub(crate) fn install() {

				    let dispatch_repair = env_enabled(std::env::var("OPENFUT_SBC_DISPATCH").ok().as_deref());

				    // The repair's evidence traces (parser, notifier, controller registration) are

				    // its decision inputs, so they follow the promoted repair, not an env var.

				    let dispatch_repair = crate::sbc_dispatch::REPAIR_PROMOTED;

				    let dispatch_trace =

				        dispatch_repair || env_enabled(std::env::var("OPENFUT_SBC_DISPATCH_TRACE").ok().as_deref());

				    let enabled =