Files
OpenFUT/openfut-adapter-fifa17
funman300 ba19954ffb fix(fifa17): consumable stacks carry their real quick-sell value
A production club displayed "Quick sell for 0 coins" for contract cards that
Core would have paid 3/13/32 for. The consumables stack wrapper hard-coded
discardValue (atom 0xd7) to 0.

The old rationale was that the client prices the card itself, the way it does
when we omit discardValue from an item. That is true of the ITEM record and not
of the STACK, and the evidence separates them cleanly:

  * item+0x38 non-zero makes the client SKIP its local computation and show our
    number -- re-proven on the live production client, 16/16 resident cards
    "SERVER-SHOWN (local calc skipped)", including the acceptance card
    235066 -> 40.
  * We send no discardValue inside a consumable's item, so +0x38 is 0 and the
    local computation DOES run and fills +0x3c correctly -- Milestone 1 measured
    3/3/32/38 there, matching this table.
  * The screen still showed 0. So the screen is not reading the item's computed
    +0x3c; it reads the stack's atom 0xd7, which we were sending as 0.

So the number belongs on the stack, and it is the SAME
discard::value_for_definition that computes the payout -- one source, so the
screen and the wallet cannot disagree. Per CARD, not per stack: FUT prices a
card and the stack is only a quantity badge over identical copies. An
unpriceable definition stays 0 rather than inventing a number.

Verified on staging across every populated family, 16/16 stacks shown ==
recovered, none zero:
  contracts 32/3/13 · healing 32/3 · training 3/13/34 · playstyle 38/38/38
  · position 36/38/38/38/38

Two tests lock it: the payout equality (with the exact 3/13/32 the production
club would have been shortchanged on) and per-card-not-per-stack pricing for a
collapsed count=3 stack.

No payout logic changed, no taxonomy change, no ownership change, no Python.
250 adapter tests, 122 host, clippy -D warnings clean, fmt clean.
2026-08-22 02:00:40 +00:00
..

openfut-adapter-fifa17

The FIFA 17 game adapter. Everything true of FIFA 17 specifically lives here, so that neither OpenFUT Core nor the generic protocol crates have to know about it.

  openfut-protocol-blaze   generic Blaze: Fire2 framing, Heat2/TDF codec
           ▲
  openfut-adapter-fifa17   THIS: command tables, response bodies, dispatch order
           ▲
  OpenFUT Core             game-independent FUT domain (not yet wired)

Status

Surface Port State
Blaze / Fire2 RPC 42130 Implemented, byte-for-byte parity-tested
Redirector (HTTPS + XML) 42127 Python only
Nucleus OAuth stub 42131 Python only
LSX / Origin 4216 Python only
Roster XML 8081 Python only
UTAS / RS4 8099 Python only
POW / EASFC 8094 / 8080 Python only

Nothing here is wired into the running backend. The crate answers frames; it opens no socket, terminates no TLS and owns no runtime. The Python backend remains the live service and the behavioural oracle.

What the adapter owns, and what it must not

Owns: component/command/notification IDs, response body shapes, dispatch ordering, session identity, the fetchClientConfig tables.

Must not own: FUT domain state. Blaze is an auth/session/config protocol — no coins, packs, clubs or squads appear on this wire — so Session holds a session key, a locale, a service name, an auth code and a flag, and that is all. When UTAS is migrated that boundary will need active defending; here it comes free.

Parity

./check-parity.sh          # oracle freshness + byte-for-byte replay
./check-parity.sh --regen  # after an intentional oracle change

fixtures/blaze_transactions.jsonl holds 49 request→response(s) transactions produced by calling the real blaze_responder_v3b.dispatch(). They replay in order against a shared session per connection, so ordering-dependent behaviour is exercised rather than assumed: preAuth captures the locale that later ALOC fields echo, and login sets the auth code getAuthToken returns afterwards.

Comparison is byte-for-byte including frame count and order — a missing post-login notification or a reply where the oracle stays silent fails here.

The suite was mutation-tested: swapping two post-login notifications, flipping one enum deep inside AccountInfo, and hardcoding an address in utas_base()/nucleus_base() were each verified to turn it red. The third initially did not, because the config templating had made those helpers dead code; the table now templates on URL-level tokens so they are the single place a URL shape is defined.

Three behaviours that are easy to get wrong

  • Login answers with four frames, in order: reply, then UserAuthenticated, UserSessionExtendedDataUpdate, UserAdded.
  • An unimplemented RPC still gets an empty reply. Silence makes the client wait for a timeout; an empty reply lets every field fall back to a client-side default and the boot continues.
  • Non-request message types get nothing at all.

No error replies are emitted. msgType 3 exists, but the error-code placement is UNRESOLVED — three clean-room sources disagree between header[14:16], a metadata ERRC, and a payload CNTX/ERRC — so emitting one would be a guess on the wire.

The client config table

fixtures/client_config.json carries 227243 rows per CFID, generated from the Python oracle and templated on {utas_base}, {nucleus_base}, {pow_content_url}, {advertise}, {bind}, {pow_host}. It is reverse-engineered data, not logic, and deriving it mechanically removes a class of transcription typo no reviewer could catch. The generator does not take its own templating on trust: it substitutes real addresses back in and diffs against the oracle for every section before writing the file.

The table must be complete, not representative. The client resolves a per-call key (FUT_RS4_URL_<CALL>) before a per-module one, and any unresolved call falls back to a real, dead EA host — that is what produced "there has been an error connecting to FIFA 17 Ultimate Team" mid-session when only the boot subset was served.

Known defect reproduced deliberately

nucleusConnect and nucleusConnectTrusted are built from the bind address, not the advertised one. On the live split deployment that means the backend tells a client on another machine to reach Nucleus at http://0.0.0.0:42131, which it cannot. Verified against the running container, not inferred.

This is reproduced exactly, because it is what the only proven-working configuration does and changing it would break parity. It also implies the Nucleus stub is not actually reached in the current remote flow. Fixing it is a separate change that needs live validation — see the vault.

Configuration

Nothing is hardcoded. AdapterConfig carries Identity (persona, ids, email, namespace, entitlement group, …) and Endpoints (advertise, bind, POW hosts, telemetry/ticker/QoS ports). Default gives the project's synthetic offline identity on loopback; a remote deployment must override advertise.

Bind and advertise are deliberately distinct: an advertised URL must carry the address the client can reach, which on a two-machine deployment is not the address the server binds.