feat(match): consume one-match training effects for the players who played
CI / Build, lint & test (push) Successful in 3m19s
CI / Build, lint & test (push) Successful in 3m19s
FIFA 17 training is a ONE-MATCH effect and the trigger is the PLAYER PLAYING, not the match completing: a card applied to someone who stays on the bench or in the reserves "will continue to benefit from the training effect until he plays" (DOCUMENTED, fifauteam's contemporaneous FIFA 17 guide, corroborated across two of its pages). So Core expires exactly the instances the caller names, and never a whole club. The participant list is supplied rather than derived here, deliberately: - The FIFA 17 match wire carries NO lineup. Across 36,149 captured requests the 19 match creates carry 5 keys and the 13 ends carry 6; the tokens "lineup" and "substitut" appear ZERO times, while "kitNumber" appears 1311 times and the same extraction recovers 23 instance ids from PUT /squad/0 in that same pcap. The absence is measured against a working positive control, not assumed. - Core must not resolve it from the squad at completion either: the squad at end is provably not the squad that started (a captured match began 20:33:20 and the next squad save landed 12 minutes later with no /match/end between). Empty participants therefore expires nothing, so a caller that cannot identify who played is inert instead of destructive. The mutation sits inside the existing single match transaction, under the same is_economic guard as coins and statistics, so NoContest voids it exactly as it voids everything else, and a rollback leaves boosts intact. Tests: participant scoping (the benched player keeps his boost), empty-participant inertness, club scoping, replay (a resubmitted completion does not consume a freshly reapplied boost), NoContest, and a BeforeCommit fault that fires AFTER the delete to prove the split-brain state "match rejected but training consumed" cannot occur.
This commit is contained in:
@@ -133,6 +133,23 @@ pub struct CompleteMatchRequest {
|
||||
/// its own wire). Only a caller using Core's season model opts in.
|
||||
#[serde(default)]
|
||||
pub advance_season: bool,
|
||||
/// Owned-card instances that TOOK THE FIELD in this match, whose one-match
|
||||
/// training effects it consumes.
|
||||
///
|
||||
/// Supplied by the caller rather than derived here, and deliberately so.
|
||||
/// FIFA 17's training rule keys on the player PLAYING, and who played is
|
||||
/// game-specific knowledge Core does not have: its match wire carries no
|
||||
/// lineup at all (LIVE_PROVEN over 36,149 captured requests). Core must also
|
||||
/// not resolve it from the squad at completion time, because the squad at
|
||||
/// end is provably not the squad that started — a captured match began at
|
||||
/// 20:33:20 and the next squad save landed 12 minutes later with no
|
||||
/// `/match/end` in between. The adapter therefore snapshots at kickoff and
|
||||
/// passes the result here.
|
||||
///
|
||||
/// Empty expires nothing, so a caller that cannot identify participants is
|
||||
/// simply inert instead of clearing a whole club.
|
||||
#[serde(default)]
|
||||
pub participants: Vec<String>,
|
||||
}
|
||||
|
||||
/// Outcome of [`crate::services::match_service::complete_match`].
|
||||
@@ -158,6 +175,10 @@ pub struct MatchCompletionResult {
|
||||
/// Owned card ids removed because their loan expired on this match. Empty
|
||||
/// unless the caller set `expire_loans`, and empty on a replay.
|
||||
pub expired_loans: Vec<String>,
|
||||
/// Owned card instances whose one-match training effect this match consumed.
|
||||
/// Empty when the caller passed no participants, and empty on a replay —
|
||||
/// the effect is consumed exactly once, by the first completion.
|
||||
pub expired_training: Vec<String>,
|
||||
/// Present when this match ended a Core season. `None` unless the caller set
|
||||
/// `advance_season`, and `None` on a replay.
|
||||
pub season_end: Option<crate::models::season::SeasonEndSummary>,
|
||||
|
||||
Reference in New Issue
Block a user