From fe41b502ac74835d0fb999bbdea4c18050a4a1f2 Mon Sep 17 00:00:00 2001 From: funman300 Date: Sat, 2 May 2026 20:43:38 +0000 Subject: [PATCH] docs: CHANGELOG + SESSION_HANDOFF refresh for v0.13.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CHANGELOG gains a [0.13.0] section covering the third UX iteration round on top of v0.12.0: - Tooltip-delay slider, streak fire, score-breakdown reveal - Card backs follow active theme - Drag-with-keyboard - Right-click radial menu Plus two code-review fixes (Removed: sccache wiring, Fixed: bundled- only font handling). The bottom-of-file compare links thread the new tag into the existing chain. Test count updated to 1053. SESSION_HANDOFF gains a "Session 7 round 3" table summarising the six commits and rolls the punch list forward — UX candidate list exhausted again, fresh six-item list seeded for a future round (daily-challenge calendar, theme-picker thumbnails, per-mode high scores, in-progress auto-save for Zen/Time Attack, configurable scoring weights, win replays). Resume prompt asks A/B/C/D about push, smoke-test, next round, or packaging. Co-Authored-By: Claude Opus 4.7 (1M context) --- CHANGELOG.md | 91 +++++++++++++++++++++++++++++++++++++++++++- SESSION_HANDOFF.md | 94 ++++++++++++++++++++-------------------------- 2 files changed, 130 insertions(+), 55 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index e58736a..da44252 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,94 @@ project follows [Semantic Versioning](https://semver.org/). _Nothing yet._ +## [0.13.0] — 2026-05-02 + +Third UX iteration round on top of v0.12.0. Six handoff candidates +shipped — three small polish items, three larger interaction +features (theme-aware backs, full keyboard play, right-click power +shortcut). Plus two code-review fixes (font handling unified, +sccache wiring removed). + +### Added + +- **Tooltip-delay slider** in Settings → Gameplay. `tooltip_delay_secs` + ranges [0.0, 1.5] in 0.1 s steps; "Instant" label when zero. + `Settings.tooltip_delay_secs` round-trips through serialise/deserialise + with `#[serde(default)]`. The hover-delay comparison in + `ui_tooltip` reads from `SettingsResource` with the existing + `MOTION_TOOLTIP_DELAY_SECS` as the test-fixture fallback. +- **Win-streak fire animation.** New `WinStreakMilestoneEvent` fires + from `stats_plugin` when `win_streak_current` crosses any of + [3, 5, 10] (only the threshold crossing — not every subsequent + win). The HUD streak readout scale-pulses 1.0 → 1.20 → 1.0 over + `MOTION_STREAK_FLOURISH_SECS` (0.6 s). +- **Score-breakdown reveal on the win modal.** Replaces the single + "Score: N" line with a per-component reveal (Base / Time bonus / + No-undo bonus / Mode multiplier / Total). Rows fade in over + `MOTION_SCORE_BREAKDOWN_FADE_SECS` (0.12 s) staggered by + `MOTION_SCORE_BREAKDOWN_STAGGER_SECS` (0.15 s). Honours + `AnimSpeed::Instant` by spawning all rows fully visible. +- **Card backs follow the active theme.** `theme.ron`'s `back` slot + now actually drives the face-down sprite. Active-theme back + rasterises alongside the faces and supersedes the legacy + `back_N.png` picker. The picker remains as a fallback for themes + that don't ship a back, and the Settings UI surfaces a caption + ("Active theme provides its own back") + dimmed swatches when + the override is in effect. +- **Keyboard-only drag-and-drop.** Tab cycles draggable card stacks, + Enter "lifts" the focused stack, arrow keys (or Tab) cycle the + legal-destination targets only, Enter confirms, Esc cancels. A + new `KeyboardDragState` resource models the two-mode flow without + changing the existing `SelectionState` contract. Mutual exclusion + with mouse drag uses a sentinel `DragState.active_touch_id = + KEYBOARD_DRAG_TOUCH_ID` (u64::MAX) so neither pipeline can + trample the other. +- **Right-click radial menu.** Hold right-click on a face-up card → + a small ring of icons appears at the cursor with one entry per + legal destination. Release over an icon → fires + `MoveRequestEvent`; release in dead space, Esc, or left-click + cancels. Skips the drag motion entirely. New `RadialMenuPlugin` + owns the flow; co-exists with the existing `RightClickHighlight` + pile-marker tint. + +### Fixed + +- **Font handling consolidated to bundled-only.** Code-review + feedback: the SVG rasteriser previously mixed + `load_system_fonts` + bundled FiraMono + a lenient resolver, + which made card text rendering depend on host fontconfig. Picked + option (a) and applied it across both layers — `font_plugin` now + embeds `assets/fonts/main.ttf` via `include_bytes!()` and + registers it with `Assets`; `svg_loader::shared_fontdb` + loads only the bundled bytes; the new `bundled_font_resolver` + ignores the SVG's `font-family` request and always returns the + single bundled face. A parse failure aborts with a clear error + ("bundled FiraMono failed to parse — binary is corrupt"). + +### Removed + +- **Project-level sccache wiring.** Code-review feedback: sccache + shouldn't be a per-project build dependency. Cargo's incremental + cache already covers the single-project case, and forcing + `rustc-wrapper = "sccache"` workspace-wide meant every contributor + had to install it. `.cargo/config.toml` deleted entirely; plain + `cargo build` now works without setup. + +### Documentation + +- `help_plugin` controls reference gains a "Mouse" section covering + double-click auto-move, right-click highlight, and the new + hold-RMB radial. +- `help_plugin` also gains a "Keyboard drag" section for the new + Tab/Enter/Arrows/Esc flow. +- Onboarding slide 3 picks up a `Tab → Enter` row referencing the + full keyboard drag path. + +### Stats + +- 1053 passing tests (was 1031 at v0.12.0 close). +- Zero clippy warnings under `--workspace --all-targets -- -D warnings`. + ## [0.12.0] — 2026-05-02 UX feel polish round on top of v0.11.0. Six small-but-tangible @@ -224,7 +312,8 @@ with no PNG artwork yet. CREDITS.md, persistent window geometry, mode-launcher Home repurpose, client-side sync round-trip integration tests. -[Unreleased]: https://github.com/funman300/Rusty_Solitaire/compare/v0.12.0...HEAD +[Unreleased]: https://github.com/funman300/Rusty_Solitaire/compare/v0.13.0...HEAD +[0.13.0]: https://github.com/funman300/Rusty_Solitaire/compare/v0.12.0...v0.13.0 [0.12.0]: https://github.com/funman300/Rusty_Solitaire/compare/v0.11.0...v0.12.0 [0.11.0]: https://github.com/funman300/Rusty_Solitaire/compare/v0.10.0...v0.11.0 [0.10.0]: https://github.com/funman300/Rusty_Solitaire/compare/v0.9.0...v0.10.0 diff --git a/SESSION_HANDOFF.md b/SESSION_HANDOFF.md index 42e9844..633f625 100644 --- a/SESSION_HANDOFF.md +++ b/SESSION_HANDOFF.md @@ -1,82 +1,67 @@ # Solitaire Quest — UX Overhaul Session Handoff -**Last updated:** 2026-05-02 (session 7, late) — Second UX iteration round complete. Six small UX feel items shipped on top of v0.11.0 and the README/CHANGELOG refresh that should have ridden along. Ready to tag v0.12.0. +**Last updated:** 2026-05-02 (session 7, late-late) — Third UX iteration round complete on top of v0.12.0. Six post-handoff candidates shipped plus two code-review fixes. Ready to tag v0.13.0. ## Status at pause -- **HEAD:** `7dba772` plus the impending CHANGELOG/handoff doc commits. Local master is **3 commits ahead** of `origin/master` (`9887343`, `ca5788f`, `7dba772` unpushed); doc commits to follow. -- **Working tree:** clean apart from this doc + CHANGELOG, both intentional. +- **HEAD:** doc-commit closing this round (CHANGELOG + handoff). Local master has the impending tag at this commit. +- **Working tree:** clean apart from untracked `CARD_PLAN.md` (intentional). - **Build:** `cargo clippy --workspace --all-targets -- -D warnings` clean. -- **Tests:** **1007 passed / 0 failed** across the workspace (+25 from session 7 morning's 982 baseline). -- **Tags on origin:** `v0.9.0`, `v0.10.0`, `v0.11.0`. Local has `v0.11.0` too. v0.12.0 is the next tag. +- **Tests:** **1053 passed / 0 failed** across the workspace (+22 from v0.12.0's 1031 baseline). +- **Tags on origin:** `v0.9.0`, `v0.10.0`, `v0.11.0`, `v0.12.0`. v0.13.0 is the next tag. ## Where we are -v0.11.0 shipped the headline structural changes (card themes, HUD overhaul, four UX feel wins, font fallback). The second UX round — six smaller items — is also done now. v0.12.0 is the right slice for them; together with the README refresh and CHANGELOG add it makes a clean release. +Post-v0.12.0 the handoff listed six "next-round candidates" — every one shipped today plus two code-review fixes (font handling unified to bundled-only, sccache wiring removed). v0.13.0 is the right slice. -The post-v0.11.0 UX candidate list is exhausted. Direction is open again. +The candidate list is exhausted again. Direction is open. ### Design direction (unchanged) - **Tone:** Balatro — chunky readable type, theatrical hierarchy, satisfying micro-interactions. - **Palette:** Midnight Purple base + Balatro yellow primary + warm magenta secondary. -- See `~/.claude/projects/-home-manage-Rusty-Solitare/memory/project_ux_overhaul_2026-04.md` (auto-memory; on a different machine, recreate this fresh from the README + ARCHITECTURE.md). +- See `~/.claude/projects/-home-manage-Rusty-Solitare/memory/project_ux_overhaul_2026-04.md` (machine-local). ### Canonical remote -`github.com/funman300/Rusty_Solitaire` is the canonical repo. Always push there. (Local clone directories may still be named `Rusty_Solitare`; that's just a directory name and works fine.) +`github.com/funman300/Rusty_Solitaire` is the canonical repo. Always push there. -## Session 7 round 1 (shipped 2026-05-02 morning) — v0.11.0 +## Session 7 round 3 (shipped 2026-05-02 late-late) — v0.13.0 | Area | Commit | What landed | |---|---|---| -| Font fallback | `fdb6c2e` | FiraMono bundled into the SVG fontdb so cards render rank/suit text on machines without Bitstream Vera Sans / Arial. Surfaced when a second-machine pull lost glyphs. | -| Unlock foundations | `95df542` | `PileType::Foundation(Suit)` → `Foundation(u8)` with claim derived from the bottom card. Save schema 1 → 2; pre-v2 saves silently fall through to fresh game. | -| Drop overlay | `f6c9166` | Soft fill + 3 px outline drawn ABOVE stacked cards for every legal target during drag. Replaces the hidden pile-marker tint. | -| Drop shadows | `f712b89` | Each card casts a 25 % black shadow; lifts to 40 % with bigger offset/halo while in the active drag set. | -| Stock badge | `655dfde` | "·N" chip at the top-right of the stock so players can see how close they are to a recycle. Hides at zero. | - -Tagged as `v0.11.0` (commit `063269c` plus URL refresh). - -## Session 7 round 2 (shipped 2026-05-02 afternoon) — v0.12.0 - -| Area | Commit | What landed | -|---|---|---| -| Aspect ratio | `13aa0fd` | `CARD_ASPECT` 1.4 → 1.4523 to match hayeah SVG dimensions; cards no longer ~3.6 % squashed. Vertical-budget math adapts via the constant. | -| Foundation flourish | `69ce9af` | King-on-foundation celebration: scale-pulse on the King, marker tints `STATE_SUCCESS`, synthesised C6→E6→G6 bell ping (~240 ms). New `FoundationCompletedEvent`. | -| Drag-cancel tween | `525fe0f` | Illegal drops glide each card back to its origin over 150 ms with a quintic ease-out (Responsive curve, zero overshoot). Audio cue still fires. ShakeAnim retained for non-drag rejection paths. | -| Focus pulse | `9887343` | Focus ring breathes at 1.4 s sin period over [0.65, 1.0] of native alpha. Static under `AnimSpeed::Instant`. | -| Achievement onboarding | `ca5788f` | First-win toast "First win! Press A to see your achievements." plus persisted `shown_achievement_onboarding` flag so the cue fires exactly once. | -| Mode Launcher shortcuts | `7dba772` | Digit 1–5 inside the Mode Launcher launches Classic / Daily / Zen / Challenge / TimeAttack. Locked modes silent no-op. Modal-scoped. | -| Docs (rode along) | `d8c7034`, `9f095c4` | README refresh for v0.11.0 features and corrected controls table; CHANGELOG.md added covering v0.9.0–v0.11.0. | - -The first three items in this round (`13aa0fd`, `69ce9af`, `525fe0f`) shipped before the v0.11.0 tag's commit window closed; treating them as v0.12.0 since v0.11.0 was already cut at `063269c`. +| Font fix | `17f9b51` | Code-review fix: bundle FiraMono via `include_bytes!()` in both `font_plugin` and `svg_loader`; drop `load_system_fonts`, drop the lenient resolver, drop the CSS-generic fallbacks. New `bundled_font_resolver` always returns the single bundled face. Parse failure aborts with a clear error. | +| sccache removal | `13dd44b` | Code-review fix: deleted `.cargo/config.toml` and the `.cargo` directory. Plain `cargo build` works without per-project setup. | +| Wave 1 bundle | `ddc8f27` | **Tooltip-delay slider** in Settings → Gameplay (0.0–1.5 s, 0.1 s steps, "Instant" label at zero). **Win-streak fire animation** at thresholds [3, 5, 10] via new `WinStreakMilestoneEvent`. **Score-breakdown reveal on win modal** with per-row stagger (Base / Time bonus / No-undo / Multiplier / Total), respects `AnimSpeed::Instant`. | +| Card-back theming | `7ed4f2c` | The active theme's `back.svg` now actually drives the face-down sprite. Legacy `back_N.png` picker remains as a fallback for themes without a back; Settings caption surfaces when the override is in effect. | +| Drag-with-keyboard | `a0fc0d2` | Tab → Enter → arrows → Enter completes a move without a mouse. New `KeyboardDragState` resource; mutual exclusion with mouse drag via `KEYBOARD_DRAG_TOUCH_ID` sentinel. Help + onboarding hotkey lists updated. | +| Right-click radial | `b37f0cb` | Hold RMB on a face-up card → ring of icons at the cursor, one per legal destination; release over an icon → `MoveRequestEvent`. New `RadialMenuPlugin`. Help controls reference gains a "Mouse" section. | ## Open punch list — release prep -1. **Tag v0.12.0** — meaningful slice since v0.11.0: six UX feel items + the README/CHANGELOG refresh. Tag at the doc-commit HEAD that closes this round. -2. **Push to origin** — three-plus commits unpushed. -3. **Desktop packaging** per `ARCHITECTURE.md §17`. The Arch PKGBUILD exists in `/home/manage/solitaire-quest-pkgbuild/` (separate repo, no remote yet). Pending: app icon, macOS `.icns` + notarisation cert, Windows `.ico` + Authenticode cert, AppImage recipe. +1. **Push** the unpushed commits to origin (5 commits now: 17f9b51, 13dd44b, ddc8f27, 7ed4f2c, a0fc0d2, b37f0cb, plus the impending doc commit). +2. **Tag v0.13.0** at the doc-commit HEAD. +3. **Desktop packaging** per `ARCHITECTURE.md §17`. The Arch PKGBUILD exists in `/home/manage/solitaire-quest-pkgbuild/` (separate repo). Pending: app icon, macOS `.icns` + notarisation cert, Windows `.ico` + Authenticode cert, AppImage recipe. ## Open punch list — UX iteration (next-round candidates) -The v0.12.0 list is exhausted. Candidates for a future round: +The v0.13.0 list is exhausted. Fresh candidates for a future round: -- **Card-back theme support** — the current theme system swaps face SVGs but not the back. Players asked for animated backs in passing. -- **Streak fire animation** in the HUD when win-streak crosses 3, 5, 10. Foundation flourish suggests the per-suit completion pattern; streak milestones are the lifetime equivalent. -- **Score-breakdown reveal** at win — show base / time-bonus / no-undo bonus / mode multiplier as the score animates up. Currently the win modal just shows the final number. -- **Right-click radial menu** for power users: hold right-click on a card → quick-drop options without dragging. -- **Drag-with-keyboard** — Tab to a card, Enter to "lift", arrow keys to choose destination, Enter to drop. Keyboard-only completion of a game. -- **Settings: tooltip-delay slider** so power users can disable the 0.5 s hover delay. Cheap. +- **In-game daily-challenge calendar** — currently the daily challenge fires once on launch; a Settings or Profile-side calendar showing past days' completion / streak status would make the progression visible. +- **Card-art preview in the theme picker** — Settings → Cosmetic shows theme name only; rendering the theme's Ace-of-Spades + back side-by-side as a thumbnail would make picking faster. +- **Per-mode high-score readout** in the Stats screen. Currently lifetime stats roll all modes together. +- **Auto-save in-progress games** in Zen / Time Attack so players who close the window mid-session don't lose their state. +- **Configurable scoring weights** for the curious — Settings → Gameplay slider for time-bonus magnitude. Cosmetic but power-user appealing. +- **Replay a winning game** — record the seed + move list at win time and offer "watch replay" from the Stats screen. ## Card-theme system (CARD_PLAN.md, fully shipped) -Seven phases landed across `b8fb3fb` → `924a1e2` in v0.11.0: +Seven phases landed across `b8fb3fb` → `924a1e2` in v0.11.0; v0.13.0's `7ed4f2c` finally consumes the per-theme `back.svg`. End-to-end: -- **Bundled default theme** ships in the binary via `embedded://` — 52 hayeah/playing-cards-assets SVGs (MIT) + a midnight-purple `back.svg` (original work). -- **User themes** live under `themes://` rooted at `solitaire_engine::assets::user_theme_dir()`. Drop a directory containing `theme.ron` + 53 SVG files; appears in the registry on next launch. -- **Importer** at `solitaire_engine::theme::import_theme(zip)` validates an archive and atomically unpacks. -- **Picker UI** in Settings → Cosmetic. +- **Bundled default theme** ships in the binary via `embedded://` — 52 hayeah/playing-cards-assets SVGs + a midnight-purple `back.svg`. +- **User themes** under `themes://`. Drop a directory containing `theme.ron` + 53 SVGs. +- **Importer** at `solitaire_engine::theme::import_theme(zip)` validates archives and atomically unpacks. +- **Picker UI** in Settings → Cosmetic; the active theme's `back` overrides the legacy `back_N.png` picker when present. ## Resume prompt @@ -84,14 +69,14 @@ Seven phases landed across `b8fb3fb` → `924a1e2` in v0.11.0: You are a senior Rust + Bevy developer working on Solitaire Quest. Working directory: . -Branch: master. Direction is OPEN — both UX iteration rounds shipped -and v0.12.0 is ready to tag. +Branch: master. Direction is OPEN — three UX iteration rounds shipped +and v0.13.0 is ready to tag. -State: HEAD at the doc-commit closing session 7 round 2. Local master +State: HEAD at the doc-commit closing session 7 round 3. Local master is several commits ahead of origin and unpushed. Working tree clean apart from untracked CARD_PLAN.md (intentional). Build: cargo clippy --workspace --all-targets -- -D warnings clean. -Tests: 1007 passed / 0 failed. +Tests: 1053 passed / 0 failed. READ FIRST (in order, before doing anything): 1. SESSION_HANDOFF.md — full state, session 7 changelog, punch list @@ -103,11 +88,12 @@ READ FIRST (in order, before doing anything): may be missing on a fresh machine) DECISION TO ASK THE PLAYER FIRST: - A. Push the unpushed commits and cut v0.12.0 now. - B. Smoke-test the new feel layer first (foundation flourish, drag - tween, focus pulse, mode digits), then tag. + A. Push and cut v0.13.0 now. + B. Smoke-test the new feel layer first (theme-aware backs, keyboard + drag, right-click radial, score-breakdown reveal, streak fire, + tooltip-delay slider), then tag. C. Skip the tag for another iteration round — see "next-round - candidates" in SESSION_HANDOFF for ideas. + candidates" in SESSION_HANDOFF for fresh ideas. D. Take the deferred desktop-packaging item (needs artwork + signing certs from the user).